Skip to content

Commit

Permalink
fix: PD1 result metric bounds
Browse files Browse the repository at this point in the history
  • Loading branch information
eddiebergman committed Dec 19, 2023
1 parent e0a9c33 commit 818cdaa
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/mfpbench/pd1/benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ class PD1ResultSimple(Result[PD1Config, int]):
"""Used for all PD1 benchmarks, except imagenet, lm1b, translate_wmt, uniref50."""

metric_defs: ClassVar[Mapping[str, Metric]] = {
"valid_error_rate": Metric(minimize=True, bounds=(0, np.inf)),
"test_error_rate": Metric(minimize=True, bounds=(0, np.inf)),
"valid_error_rate": Metric(minimize=True, bounds=(0, 1)),
"test_error_rate": Metric(minimize=True, bounds=(0, 1)),
"train_cost": Metric(minimize=True, bounds=(0, np.inf)),
}
default_value_metric: ClassVar[str] = "valid_error_rate"
Expand All @@ -54,7 +54,7 @@ class PD1ResultTransformer(Result[PD1Config, int]):
"""Imagenet, lm1b, translate_wmt, uniref50, cifar100 contains no test error."""

metric_defs: ClassVar[Mapping[str, Metric]] = {
"valid_error_rate": Metric(minimize=True, bounds=(0, np.inf)),
"valid_error_rate": Metric(minimize=True, bounds=(0, 1)),
"train_cost": Metric(minimize=True, bounds=(0, np.inf)),
}
default_value_metric: ClassVar[str] = "valid_error_rate"
Expand Down

0 comments on commit 818cdaa

Please sign in to comment.