-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: optimizers #167
Open
eddiebergman
wants to merge
16
commits into
master
Choose a base branch
from
cleanup-mf-heirarchies
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor: optimizers #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced with a partial of `SuccessiveHalvingBase`
The only thing inheriting from it was `PriorBand`, which ended up replacing all the defaults of it's `__init__()`. The only other thing the `HyperbandCustomDefault.__init__()` did was change the sampling args of the SH brackets, which then `PriorBand` would overwrite it its own `__init__()`.
The only user of the was `PriorBand`, in the only thing it did was explicitly pass `use_priors=`True`. Everything else it set was overwritten by `PriorBand` passing down its args.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Some notes:
super()
calls that call the base class, which calls the subclass, which calls the base class and so on. In fact most of the optimizers are now a dataclass which just looks like this.BracketOptimizer
SearchSpace
as a config. This is probably only relevant for benchmarkingTODO
BracketOptimizer
, previously a mixin class calledMFBOBase
. This can mostly just re-use the things fromgp
and is essentially just aSampler
that can be used. Here's a snippet from theBracketOptimizer
. It we would essentially just use it as the sampler when the bracket saysnext_action=("new", rung)
, signalling that a new sample has to happen at a given rung.