virtio_fs_share_data_hugepage: correct cache argument #4241
Conversation
|
@hellohellenmao , could you help review this one ? Thank you. |
|
(2/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.virtio_fs_share_data_hugepage.basic_test.with_cache.auto.q35: PASS (70.81 s) |
|
LGTM |
|
@YongxueHong Could you please help to take a review here? THanks |
|
Hi @MiriamDeng @fbq815 @xiagao |
| - none: | ||
| fs_binary_extra_options += ",cache=none" | ||
| fs_binary_extra_options += " --cache=never" |
There was a problem hiding this comment.
Hi @zhaojunyao7
Do we consider updating the variant name to never?
I prefer to update it since it is more earlier to understand the case purpose.
Pls let me know your opinions. Thanks.
zhaojunyao7
force-pushed
the
KVMAUTOMA-2917
branch
from
f4ab925 to
1a525be
Compare
change cache argument of virtiofsd from',cache=' to ' --cache=' and update the cache mode 'none' to 'never' to match with the latest production behavior. Signed-off-by: Junyao Zhao <[email protected]>
zhaojunyao7
force-pushed
the
KVMAUTOMA-2917
branch
from
1a525be to
d22f731
Compare
|
@YongxueHong Thanks for you advice, updated the variant name to never. |
|
It looks good to me. ACK. |
change cache argument of virtiofsd from',cache=' to ' --cache=' and update the cache mode 'none' to 'never' to match with the latest production behavior.
ID:2917
Signed-off-by: Junyao Zhao [email protected]