feat(psim)!: change a setting parameter type from bool to string #8331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:launch
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
yuki-takagi-66
changed the title
4 tasks
yuki-takagi-66
changed the title
3 tasks
yuki-takagi-66
requested review from
KeisukeShima,
taikitanaka3,
TakaHoribe,
takayuki5168 and
tkimura4
as code owners
yuki-takagi-66
added
the
run:build-and-test-differential
yuki-takagi-66
force-pushed
the
takagi/psim-localization_sim_mode
branch
from
79f0f99 to
27fd3ca
Compare
yukkysaito
reviewed
Aug 9, 2024
TakaHoribe
reviewed
Aug 9, 2024
| @@ -9,7 +9,7 @@ | |||
| <arg name="launch_simulator_perception_modules" default="true"/> | |||
| <arg name="launch_dummy_perception"/> | |||
| <arg name="launch_dummy_vehicle"/> | |||
| <arg name="launch_dummy_localization"/> | |||
| <arg name="localization_sim_mode"/> | |||
There was a problem hiding this comment.
Suggested change
| <arg name="localization_sim_mode"/> | |
| <arg name="localization_sim_mode", description="select localization mode. Options are 'none' or 'api'. 'api' starts an external API for initial position estimation. 'none' does not start any localization-related process."/> |
There was a problem hiding this comment.
To enrich the description.
TakaHoribe
approved these changes
Aug 9, 2024
yuki-takagi-66
changed the title
yuki-takagi-66
changed the title
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
yuki-takagi-66
force-pushed
the
takagi/psim-localization_sim_mode
branch
from
9fb858f to
49a0c62
Compare
yuki-takagi-66
changed the title
yuki-takagi-66
merged commit 31263bd
into
autowarefoundation:main
25 of 26 checks passed
xtk8532704
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 15, 2024
…owarefoundation#8331) * change a param type, bool to string * add param description, add null tag group for the null option --------- Signed-off-by: Yuki Takagi <[email protected]> Signed-off-by: xtk8532704 <[email protected]>
kosuke55
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 22, 2024
…owarefoundation#8331) * change a param type, bool to string * add param description, add null tag group for the null option --------- Signed-off-by: Yuki Takagi <[email protected]>
kosuke55
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 29, 2024
…owarefoundation#8331) * change a param type, bool to string * add param description, add null tag group for the null option --------- Signed-off-by: Yuki Takagi <[email protected]>
yuki-takagi-66
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 18, 2024
…owarefoundation#8331) * change a param type, bool to string * add param description, add null tag group for the null option --------- Signed-off-by: Yuki Takagi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the PR to follow up on the launch side PR autowarefoundation/autoware_launch#1106.
For more details, please see the launch PR
Related links
This PR is a part of the following issue.
autowarefoundation/autoware_launch#1100
How was this PR tested?
psim and scenario_sim
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.