Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lane_change): refactor lane change parameters #9403

Merged

Conversation

mkquda
Copy link
Contributor

@mkquda mkquda commented Nov 20, 2024

Description

Refactor lane change parameters to:

  • group related parameters into structs
  • shorten long parameter names where possible
  • improve code structuring

Changes

  • Move lane change parameters to separate header file parameters.hpp
  • Add new struct TrajectoryParameters
  • Add new struct SafetyParameters
  • Add new struct CollisionCheckParameters
  • update lane_change.param.yaml
  • update README

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

ROS Parameter Changes

Modifications

Trajectory generation parameters
Version Parameter Name Type Default Value
Old prepare_duration double 4.0
New trajectory.prepare_duration double 4.0
Old lane_changing_lateral_jerk double 0.5
New trajectory.lateral_jerk double 0.5
Old minimum_lane_changing_velocity double 2.78
New trajectory.min_velocity double 2.78
Old longitudinal_acceleration_sampling_num int 5
New trajectory.lon_acc_sampling_num int 5
Old lateral_acceleration_sampling_num int 3
New trajectory.lat_acc_sampling_num int 3
Old max_longitudinal_acc double 1.0
New trajectory.max_longitudinal_acc double 1.0
Old min_longitudinal_acc double -1.0
New trajectory.min_longitudinal_acc double -1.0
Collision check parameters
Version Parameter Name Type Default Value
Old enable_collision_check_for_prepare_phase.general_lanes bool false
New collision_check.enable_for_prepare_phase.general_lanes bool false
Old enable_collision_check_for_prepare_phase.intersection bool true
New collision_check.enable_for_prepare_phase.intersection bool true
Old enable_collision_check_for_prepare_phase.turns bool true
New collision_check.enable_for_prepare_phase.turns bool true
Old prediction_time_resolution double 0.5
New collision_check.prediction_time_resolution double 0.5
Old safety_check.collision_check_yaw_diff_threshold double 3.1416
New collision_check.yaw_diff_threshold double 3.1416
Old check_objects_on_current_lanes bool false
New collision_check.check_current_lanes bool false
Old check_objects_on_other_lanes bool false
New collision_check.check_other_lanes bool false
Old use_all_predicted_path bool false
New collision_check.use_all_predicted_paths bool false

Effects on system behavior

None.

Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Nov 20, 2024
Copy link

github-actions bot commented Nov 20, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mkquda mkquda marked this pull request as ready for review November 21, 2024 23:22
@mkquda mkquda added run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Nov 21, 2024
Signed-off-by: mohammad alqudah <[email protected]>
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 73.21429% with 60 lines in your changes missing coverage. Please review.

Project coverage is 28.95%. Comparing base (740d42a) to head (29604aa).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
...are_behavior_path_lane_change_module/src/scene.cpp 23.80% 28 Missing and 4 partials ⚠️
...e_behavior_path_lane_change_module/src/manager.cpp 84.28% 20 Missing and 2 partials ⚠️
...avior_path_lane_change_module/utils/parameters.hpp 73.33% 0 Missing and 4 partials ⚠️
...havior_path_lane_change_module/src/utils/utils.cpp 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9403      +/-   ##
==========================================
- Coverage   29.00%   28.95%   -0.06%     
==========================================
  Files        1427     1429       +2     
  Lines      108199   108194       -5     
  Branches    41386    41342      -44     
==========================================
- Hits        31386    31323      -63     
- Misses      73776    73834      +58     
  Partials     3037     3037              
Flag Coverage Δ *Carryforward flag
differential 19.91% <73.21%> (?)
total 28.86% <ø> (-0.14%) ⬇️ Carriedforward from 13cbe8e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…nge_module/include/autoware/behavior_path_lane_change_module/utils/parameters.hpp

Co-authored-by: Zulfaqar Azmi <[email protected]>
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mkquda and others added 3 commits November 26, 2024 09:09
@mkquda mkquda merged commit abf0f23 into autowarefoundation:main Nov 26, 2024
31 of 32 checks passed
@mkquda mkquda deleted the RT1-8533-refactor-lane-change-parameters branch November 26, 2024 05:10
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Dec 20, 2024
…ation#9403)

* refactor lane change parameters

Signed-off-by: mohammad alqudah <[email protected]>

* update lane change param yaml

Signed-off-by: mohammad alqudah <[email protected]>

* update lane change README

Signed-off-by: mohammad alqudah <[email protected]>

* regroup some parameters

Signed-off-by: mohammad alqudah <[email protected]>

* run pre-commit prettier step

Signed-off-by: mohammad alqudah <[email protected]>

* Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/include/autoware/behavior_path_lane_change_module/utils/parameters.hpp

Co-authored-by: Zulfaqar Azmi <[email protected]>

* Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md

Co-authored-by: Zulfaqar Azmi <[email protected]>

* Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md

Co-authored-by: Zulfaqar Azmi <[email protected]>

* apply pre-commit checks

Signed-off-by: mohammad alqudah <[email protected]>

---------

Signed-off-by: mohammad alqudah <[email protected]>
Co-authored-by: Zulfaqar Azmi <[email protected]>
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request Dec 20, 2024
…ation#9403)

* refactor lane change parameters

Signed-off-by: mohammad alqudah <[email protected]>

* update lane change param yaml

Signed-off-by: mohammad alqudah <[email protected]>

* update lane change README

Signed-off-by: mohammad alqudah <[email protected]>

* regroup some parameters

Signed-off-by: mohammad alqudah <[email protected]>

* run pre-commit prettier step

Signed-off-by: mohammad alqudah <[email protected]>

* Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/include/autoware/behavior_path_lane_change_module/utils/parameters.hpp

Co-authored-by: Zulfaqar Azmi <[email protected]>

* Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md

Co-authored-by: Zulfaqar Azmi <[email protected]>

* Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md

Co-authored-by: Zulfaqar Azmi <[email protected]>

* apply pre-commit checks

Signed-off-by: mohammad alqudah <[email protected]>

---------

Signed-off-by: mohammad alqudah <[email protected]>
Co-authored-by: Zulfaqar Azmi <[email protected]>
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request Dec 21, 2024
…ation#9403)

* refactor lane change parameters

Signed-off-by: mohammad alqudah <[email protected]>

* update lane change param yaml

Signed-off-by: mohammad alqudah <[email protected]>

* update lane change README

Signed-off-by: mohammad alqudah <[email protected]>

* regroup some parameters

Signed-off-by: mohammad alqudah <[email protected]>

* run pre-commit prettier step

Signed-off-by: mohammad alqudah <[email protected]>

* Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/include/autoware/behavior_path_lane_change_module/utils/parameters.hpp

Co-authored-by: Zulfaqar Azmi <[email protected]>

* Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md

Co-authored-by: Zulfaqar Azmi <[email protected]>

* Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md

Co-authored-by: Zulfaqar Azmi <[email protected]>

* apply pre-commit checks

Signed-off-by: mohammad alqudah <[email protected]>

---------

Signed-off-by: mohammad alqudah <[email protected]>
Co-authored-by: Zulfaqar Azmi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants