-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(lane_change): refactor lane change parameters #9403
refactor(lane_change): refactor lane change parameters #9403
Conversation
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9403 +/- ##
==========================================
- Coverage 29.00% 28.95% -0.06%
==========================================
Files 1427 1429 +2
Lines 108199 108194 -5
Branches 41386 41342 -44
==========================================
- Hits 31386 31323 -63
- Misses 73776 73834 +58
Partials 3037 3037
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...th_lane_change_module/include/autoware/behavior_path_lane_change_module/utils/parameters.hpp
Outdated
Show resolved
Hide resolved
…nge_module/include/autoware/behavior_path_lane_change_module/utils/parameters.hpp Co-authored-by: Zulfaqar Azmi <[email protected]>
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…nge_module/README.md Co-authored-by: Zulfaqar Azmi <[email protected]>
…nge_module/README.md Co-authored-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
…ation#9403) * refactor lane change parameters Signed-off-by: mohammad alqudah <[email protected]> * update lane change param yaml Signed-off-by: mohammad alqudah <[email protected]> * update lane change README Signed-off-by: mohammad alqudah <[email protected]> * regroup some parameters Signed-off-by: mohammad alqudah <[email protected]> * run pre-commit prettier step Signed-off-by: mohammad alqudah <[email protected]> * Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/include/autoware/behavior_path_lane_change_module/utils/parameters.hpp Co-authored-by: Zulfaqar Azmi <[email protected]> * Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md Co-authored-by: Zulfaqar Azmi <[email protected]> * Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md Co-authored-by: Zulfaqar Azmi <[email protected]> * apply pre-commit checks Signed-off-by: mohammad alqudah <[email protected]> --------- Signed-off-by: mohammad alqudah <[email protected]> Co-authored-by: Zulfaqar Azmi <[email protected]>
…ation#9403) * refactor lane change parameters Signed-off-by: mohammad alqudah <[email protected]> * update lane change param yaml Signed-off-by: mohammad alqudah <[email protected]> * update lane change README Signed-off-by: mohammad alqudah <[email protected]> * regroup some parameters Signed-off-by: mohammad alqudah <[email protected]> * run pre-commit prettier step Signed-off-by: mohammad alqudah <[email protected]> * Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/include/autoware/behavior_path_lane_change_module/utils/parameters.hpp Co-authored-by: Zulfaqar Azmi <[email protected]> * Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md Co-authored-by: Zulfaqar Azmi <[email protected]> * Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md Co-authored-by: Zulfaqar Azmi <[email protected]> * apply pre-commit checks Signed-off-by: mohammad alqudah <[email protected]> --------- Signed-off-by: mohammad alqudah <[email protected]> Co-authored-by: Zulfaqar Azmi <[email protected]>
…ation#9403) * refactor lane change parameters Signed-off-by: mohammad alqudah <[email protected]> * update lane change param yaml Signed-off-by: mohammad alqudah <[email protected]> * update lane change README Signed-off-by: mohammad alqudah <[email protected]> * regroup some parameters Signed-off-by: mohammad alqudah <[email protected]> * run pre-commit prettier step Signed-off-by: mohammad alqudah <[email protected]> * Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/include/autoware/behavior_path_lane_change_module/utils/parameters.hpp Co-authored-by: Zulfaqar Azmi <[email protected]> * Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md Co-authored-by: Zulfaqar Azmi <[email protected]> * Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md Co-authored-by: Zulfaqar Azmi <[email protected]> * apply pre-commit checks Signed-off-by: mohammad alqudah <[email protected]> --------- Signed-off-by: mohammad alqudah <[email protected]> Co-authored-by: Zulfaqar Azmi <[email protected]>
Description
Refactor lane change parameters to:
Changes
parameters.hpp
TrajectoryParameters
SafetyParameters
CollisionCheckParameters
lane_change.param.yaml
README
Related links
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
ROS Parameter Changes
Modifications
Trajectory generation parameters
prepare_duration
double
4.0
trajectory.prepare_duration
double
4.0
lane_changing_lateral_jerk
double
0.5
trajectory.lateral_jerk
double
0.5
minimum_lane_changing_velocity
double
2.78
trajectory.min_velocity
double
2.78
longitudinal_acceleration_sampling_num
int
5
trajectory.lon_acc_sampling_num
int
5
lateral_acceleration_sampling_num
int
3
trajectory.lat_acc_sampling_num
int
3
max_longitudinal_acc
double
1.0
trajectory.max_longitudinal_acc
double
1.0
min_longitudinal_acc
double
-1.0
trajectory.min_longitudinal_acc
double
-1.0
Collision check parameters
enable_collision_check_for_prepare_phase.general_lanes
bool
false
collision_check.enable_for_prepare_phase.general_lanes
bool
false
enable_collision_check_for_prepare_phase.intersection
bool
true
collision_check.enable_for_prepare_phase.intersection
bool
true
enable_collision_check_for_prepare_phase.turns
bool
true
collision_check.enable_for_prepare_phase.turns
bool
true
prediction_time_resolution
double
0.5
collision_check.prediction_time_resolution
double
0.5
safety_check.collision_check_yaw_diff_threshold
double
3.1416
collision_check.yaw_diff_threshold
double
3.1416
check_objects_on_current_lanes
bool
false
collision_check.check_current_lanes
bool
false
check_objects_on_other_lanes
bool
false
collision_check.check_other_lanes
bool
false
use_all_predicted_path
bool
false
collision_check.use_all_predicted_paths
bool
false
Effects on system behavior
None.