Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(static_centerline_generator): several bug fixes #9426

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Nov 21, 2024

Description

Several bug fixes including

  • fix package dependency
  • use discontinuous curvature calculation instead of spline interpolation which is more robust to the trajectory's interval length
  • show steer angle instead of curvature which is easy to understand

Related links

How was this PR tested?

unit test passed.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Nov 21, 2024
Copy link

github-actions bot commented Nov 21, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 29.60%. Comparing base (ca507d6) to head (6031a1f).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...generator/src/static_centerline_generator_node.cpp 66.66% 1 Missing and 1 partial ⚠️
...n/autoware_vehicle_info_utils/src/vehicle_info.cpp 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9426   +/-   ##
=======================================
  Coverage   29.60%   29.60%           
=======================================
  Files        1443     1442    -1     
  Lines      108516   108531   +15     
  Branches    41385    41386    +1     
=======================================
+ Hits        32122    32129    +7     
- Misses      72999    73004    +5     
- Partials     3395     3398    +3     
Flag Coverage Δ *Carryforward flag
differential 34.32% <72.72%> (?)
total 29.59% <ø> (-0.01%) ⬇️ Carriedforward from 27538fe

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 marked this pull request as ready for review December 10, 2024 02:38
@takayuki5168 takayuki5168 force-pushed the fix/static-centerline-generator branch from a406a11 to 27538fe Compare December 10, 2024 02:39
@takayuki5168
Copy link
Contributor Author

@kosuke55
Please approve the PR if the changes look good to you. No need to go deep into the changes.

Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168
Copy link
Contributor Author

@kosuke55
ping

@takayuki5168 takayuki5168 merged commit 3cfb03e into autowarefoundation:main Dec 11, 2024
32 of 33 checks passed
@takayuki5168 takayuki5168 deleted the fix/static-centerline-generator branch December 11, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants