Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(autoware_behavior_path_start_planner_module): add test helper and implement unit tests for FreespacePullOut #9832

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Jan 6, 2025

Description

  • Removed dependency on LaneDepartureChecker as a constructor parameter across multiple planners:

    • ShiftPullOut
    • GeometricPullOut
    • BezierPullOut
    • FreespacesPullOut
  • Changed LaneDepartureChecker initialization to be handled internally within each planner class instead of being passed in

  • Modified planner interfaces to pass PlannerData directly in plan() methods instead of storing it as member variable

  • Added test helper classes and improved test structure for Start Planner module

  • Simplified constructor signatures by removing redundant vehicle info parameter since it's already available in base class

  • Updated test cases to reflect the new interfaces and initialization patterns

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…sary time_keeper parameter from pull-out planners

Signed-off-by: Kyoichi Sugahara <[email protected]>
Signed-off-by: Kyoichi Sugahara <[email protected]>
…per parameter from pull-out planners

Signed-off-by: Kyoichi Sugahara <[email protected]>
…lization and parameter handling

Signed-off-by: kyoichi-sugahara <[email protected]>
…r/lane_departure_checker/update_constructor

Signed-off-by: Kyoichi Sugahara <[email protected]>
…o refactor/start_planner/change_interface

Signed-off-by: Kyoichi Sugahara <[email protected]>
…artureChecker dependency from pull-out planners

Signed-off-by: Kyoichi Sugahara <[email protected]>
@kyoichi-sugahara kyoichi-sugahara changed the title test(autoware_behavior_path_goal_planner_module): add test helper and implement unit tests for FreespacePullOut test(autoware_behavior_path_start_planner_module): add test helper and implement unit tests for FreespacePullOut Jan 6, 2025
@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kyoichi-sugahara kyoichi-sugahara force-pushed the test/start_planner/add_start_planner_test_helper branch from 687d64c to e4c5a29 Compare January 10, 2025 07:58
@github-actions github-actions bot removed the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Jan 10, 2025
@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 48.97959% with 25 lines in your changes missing coverage. Please review.

Project coverage is 29.57%. Comparing base (76aa83f) to head (4470eba).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 5 Missing ⚠️
..._module/src/pull_over_planner/bezier_pull_over.cpp 0.00% 4 Missing ⚠️
..._start_planner_module/src/start_planner_module.cpp 0.00% 4 Missing ⚠️
...dule/src/pull_over_planner/geometric_pull_over.cpp 0.00% 3 Missing ⚠️
...r_module/src/pull_over_planner/shift_pull_over.cpp 0.00% 3 Missing ⚠️
...dule/src/pull_over_planner/freespace_pull_over.cpp 0.00% 2 Missing ⚠️
...r_path_start_planner_module/src/shift_pull_out.cpp 83.33% 1 Missing and 1 partial ⚠️
...th_start_planner_module/src/geometric_pull_out.cpp 87.50% 0 Missing and 1 partial ⚠️
...start_planner_module/src/pull_out_planner_base.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9832      +/-   ##
==========================================
+ Coverage   29.43%   29.57%   +0.14%     
==========================================
  Files        1444     1449       +5     
  Lines      108284   107970     -314     
  Branches    42187    42061     -126     
==========================================
+ Hits        31870    31936      +66     
+ Misses      73332    72949     -383     
- Partials     3082     3085       +3     
Flag Coverage Δ *Carryforward flag
differential 13.00% <48.97%> (?)
total 29.53% <ø> (+0.10%) ⬆️ Carriedforward from e4c5a29

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara merged commit 9546c0e into autowarefoundation:main Jan 10, 2025
37 of 38 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the test/start_planner/add_start_planner_test_helper branch January 10, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants