-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(autoware_behavior_path_start_planner_module): add test helper and implement unit tests for FreespacePullOut #9832
Conversation
…sary time_keeper parameter from pull-out planners Signed-off-by: Kyoichi Sugahara <[email protected]>
Signed-off-by: Kyoichi Sugahara <[email protected]>
…per parameter from pull-out planners Signed-off-by: Kyoichi Sugahara <[email protected]>
…lization and parameter handling Signed-off-by: kyoichi-sugahara <[email protected]>
…r/lane_departure_checker/update_constructor Signed-off-by: Kyoichi Sugahara <[email protected]>
… out planners Signed-off-by: kyoichi-sugahara <[email protected]>
…o refactor/start_planner/change_interface Signed-off-by: Kyoichi Sugahara <[email protected]>
…artureChecker dependency from pull-out planners Signed-off-by: Kyoichi Sugahara <[email protected]>
Signed-off-by: Kyoichi Sugahara <[email protected]>
…ctors Signed-off-by: Kyoichi Sugahara <[email protected]>
… FreespacePullOut Signed-off-by: Kyoichi Sugahara <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
…lper Signed-off-by: Kyoichi Sugahara <[email protected]>
…ization Signed-off-by: Kyoichi Sugahara <[email protected]>
687d64c
to
e4c5a29
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9832 +/- ##
==========================================
+ Coverage 29.43% 29.57% +0.14%
==========================================
Files 1444 1449 +5
Lines 108284 107970 -314
Branches 42187 42061 -126
==========================================
+ Hits 31870 31936 +66
+ Misses 73332 72949 -383
- Partials 3082 3085 +3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9546c0e
into
autowarefoundation:main
Description
Removed dependency on
LaneDepartureChecker
as a constructor parameter across multiple planners:Changed
LaneDepartureChecker
initialization to be handled internally within each planner class instead of being passed inModified planner interfaces to pass
PlannerData
directly in plan() methods instead of storing it as member variableAdded test helper classes and improved test structure for Start Planner module
Simplified constructor signatures by removing redundant vehicle info parameter since it's already available in base class
Updated test cases to reflect the new interfaces and initialization patterns
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.