Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_pointcloud_preprocessor): tier4_debug_msgs changed to autoware_internal_debug_msgs in autoware_pointcloud_preprocessor #9920

Conversation

vish0012
Copy link
Contributor

…es sensing/autoware_pointcloud_preprocessor

Description

The tier4_debug_msgs have been replaced with autoware_internal_debug_msgs to enhance clarity and consistency in the codebase.

Related links

autowarefoundation/autoware#5580

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…es sensing/autoware_pointcloud_preprocessor

Signed-off-by: vish0012 <[email protected]>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) labels Jan 15, 2025
Copy link

github-actions bot commented Jan 15, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 15, 2025
@mitsudome-r mitsudome-r changed the title feat: tier4_debug_msgs changed to autoware_internal_debug_msgs in fil… feat(autoware_pointcloud_preprocessor): tier4_debug_msgs changed to autoware_internal_debug_msgs in autoware_pointcloud_preprocessor Jan 15, 2025
@mitsudome-r mitsudome-r enabled auto-merge (squash) January 15, 2025 06:24
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 11.53846% with 23 lines in your changes missing coverage. Please review.

Project coverage is 29.21%. Comparing base (e96b361) to head (4c0a398).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...or/src/outlier_filter/ring_outlier_filter_node.cpp 0.00% 4 Missing ⚠️
...processor/src/blockage_diag/blockage_diag_node.cpp 0.00% 3 Missing ⚠️
...atenate_data/concatenate_and_time_sync_nodelet.cpp 0.00% 3 Missing ⚠️
...r/src/concatenate_data/concatenate_pointclouds.cpp 0.00% 3 Missing ⚠️
...essor/src/crop_box_filter/crop_box_filter_node.cpp 0.00% 3 Missing ⚠️
...distortion_corrector/distortion_corrector_node.cpp 0.00% 3 Missing ⚠️
...r/src/time_synchronizer/time_synchronizer_node.cpp 0.00% 3 Missing ⚠️
...outlier_filter/dual_return_outlier_filter_node.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9920      +/-   ##
==========================================
- Coverage   29.21%   29.21%   -0.01%     
==========================================
  Files        1425     1426       +1     
  Lines      107731   107763      +32     
  Branches    42178    42180       +2     
==========================================
+ Hits        31475    31479       +4     
- Misses      73159    73188      +29     
+ Partials     3097     3096       -1     
Flag Coverage Δ *Carryforward flag
differential 23.78% <11.53%> (?)
differential-cuda 23.78% <11.53%> (?)
total 29.22% <ø> (+<0.01%) ⬆️ Carriedforward from e96b361

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitsudome-r mitsudome-r merged commit 95e7939 into autowarefoundation:main Jan 15, 2025
33 of 34 checks passed
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Jan 15, 2025
…utoware_internal_debug_msgs in autoware_pointcloud_preprocessor (autowarefoundation#9920)

feat: tier4_debug_msgs changed to autoware_internal_debug_msgs in files sensing/autoware_pointcloud_preprocessor

Signed-off-by: vish0012 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants