Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(velocity_smoother): introduce diagnostics #9933

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jan 16, 2025

Description

Removed the temporary message of StopSpeedExcceded in tier4_msgs.
Instead, introduced diagnostics.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 16, 2025
Copy link

github-actions bot commented Jan 16, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@takayuki5168 takayuki5168 marked this pull request as ready for review January 16, 2025 04:41
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.21%. Comparing base (a2755a4) to head (973b161).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9933      +/-   ##
==========================================
- Coverage   29.21%   29.21%   -0.01%     
==========================================
  Files        1425     1426       +1     
  Lines      107729   107744      +15     
  Branches    42197    42196       -1     
==========================================
+ Hits        31474    31476       +2     
- Misses      73206    73222      +16     
+ Partials     3049     3046       -3     
Flag Coverage Δ *Carryforward flag
differential 30.64% <100.00%> (?)
total 29.21% <ø> (-0.01%) ⬇️ Carriedforward from f776099

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

2 participants