Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the issue of getting "Unknown" value with platform.processor #2897

Merged

Conversation

Naresh-ibm
Copy link
Collaborator

platform.processor is returning the unknown value and hence tests were failing. So changed this checking with other util functions like cpu.get_arch()

platform.processor is returning the unknown value and hence tests
were failing. So changed this checking with other util functions
like cpu.get_arch()

Signed-off-by: Naresh Bannoth <[email protected]>
@Naresh-ibm
Copy link
Collaborator Author

Before fix
-------------

# avocado run --max-parallel-tasks=1 pci_hotplug.py -m pci_hotplug.py.data/pci_hotplug.yaml 
JOB ID     : 34e727d98d44339e59dcdc2dbc0c229c84e96d1b
JOB LOG    : /root/avocado-fvt-wrapper/results/job-2024-09-19T04.47-34e727d/job.log
 (1/1) pci_hotplug.py:PCIHotPlugTest.test;run-peer_ip-3dcc: STARTED
 (1/1) pci_hotplug.py:PCIHotPlugTest.test;run-peer_ip-3dcc: CANCEL: Processor is not ppc64 (0.01 s)
RESULTS    : PASS 0 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 1
JOB HTML   : /root/avocado-fvt-wrapper/results/job-2024-09-19T04.47-34e727d/results.html
JOB TIME   : 23.01 s

After fix
-------------

]# avocado run --max-parallel-tasks=1 pci_hotplug.py -m pci_hotplug.py.data/pci_hotplug.yaml
JOB ID     : c857674a96c01dc50eb6dffd3037496c1648d361
JOB LOG    : /root/avocado-fvt-wrapper/results/job-2024-09-19T05.47-c857674/job.log
 (1/1) pci_hotplug.py:PCIHotPlugTest.test;run-peer_ip-3dcc: STARTED
 (1/1) pci_hotplug.py:PCIHotPlugTest.test;run-peer_ip-3dcc: PASS (1.28 s)
RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /root/avocado-fvt-wrapper/results/job-2024-09-19T05.47-c857674/results.html
JOB TIME   : 115.84 s


@Naresh-ibm Naresh-ibm self-assigned this Sep 19, 2024
platform.processor is returning the unknown value and hence tests
were failing. So changed this checking with other util functions
like cpu.get_arch()

Signed-off-by: Naresh Bannoth <[email protected]>
@Naresh-ibm Naresh-ibm force-pushed the platform_ppc_failure branch from 7f362c9 to ecf26c5 Compare October 21, 2024 06:03
@abdhaleegit
Copy link
Collaborator

abdhaleegit commented Oct 21, 2024

@Naresh-ibm Please wait for avocado-framework/avocado#5993 when this is merged.. it is dependent

@abdhaleegit abdhaleegit self-requested a review October 21, 2024 10:25
io/pci/pci_hotplug.py Show resolved Hide resolved
memory/memhotplug.py Show resolved Hide resolved
Copy link
Collaborator

@abdhaleegit abdhaleegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abdhaleegit abdhaleegit merged commit d752a5a into avocado-framework-tests:master Oct 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants