Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils_netperf: bypass compilation failure #3930

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

luckyh
Copy link
Contributor

@luckyh luckyh commented Jun 17, 2024

Starting from gcc 14.0, implicit function declarations are treated as errors by default [1], which caused the following failure been observed during the compilation.

netlib.c:2343:9: error: implicit declaration of function ...
...
make[3]: *** [Makefile:454: netlib.o] Error 1

One contributor has already sent a PR [2] to fix the issue to the netperf upstream, however, it has not been merged yet since a year ago. At the moment, let's just bypass this issue, while waiting for a regular fix to be done.

References:
[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91092
[2] HewlettPackard/netperf#74

ID: 2505

Starting from gcc 14.0, implicit function declarations are treated
as errors by default [1], which caused the following failure been
observed during the compilation.

> netlib.c:2343:9: error: implicit declaration of function ...
> ...
> make[3]: *** [Makefile:454: netlib.o] Error 1

One contributor has already sent a PR [2] to fix the issue to the
netperf upstream, however, it has not been merged yet since a year
ago. At the moment, let's just bypass this issue, while waiting
for a regular fix to be done.

References:
[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91092
[2] HewlettPackard/netperf#74

Signed-off-by: Xu Han <[email protected]>
@luckyh
Copy link
Contributor Author

luckyh commented Jun 17, 2024

@yanglei-rh @Yingshun would you mind to help review this one? thanks in advance!

Copy link
Contributor

@yanglei-rh yanglei-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It can test pass on my side.

@Yingshun Yingshun merged commit 075b81e into avocado-framework:master Jun 18, 2024
50 checks passed
quanwenli added a commit to quanwenli/tp-qemu that referenced this pull request Jun 20, 2024
quanwenli added a commit to quanwenli/tp-qemu that referenced this pull request Jun 20, 2024
quanwenli added a commit to quanwenli/tp-qemu that referenced this pull request Jun 20, 2024
quanwenli added a commit to quanwenli/tp-qemu that referenced this pull request Jun 25, 2024
quanwenli added a commit to quanwenli/tp-qemu that referenced this pull request Jul 18, 2024
bypass compilation with -Wno-implicit-function-declaration
More information reference [1]

[1] avocado-framework/avocado-vt#3930

Signed-off-by: Wenli Quan <[email protected]>
quanwenli added a commit to quanwenli/tp-qemu that referenced this pull request Jul 18, 2024
bypass compilation with -Wno-implicit-function-declaration
More information reference [1]

[1] avocado-framework/avocado-vt#3930

Signed-off-by: Wenli Quan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants