Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeclimate removal #6055

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

richtja
Copy link
Contributor

@richtja richtja commented Oct 29, 2024

Since codeclimate check hasn't been accurate and often creates false positive, the positives of having such tool is much lower that the negative impact on PRs. Therefore, this PR removes all occurrences of codeclimate code from Avocado.

Since codeclimate check hasn't been accurate and often creates false
positive, the positives of having such tool is much lower that the
negative impact on PRs. Therefore, this commit removes all occurrences
of codeclimate code from Avocado.

Signed-off-by: Jan Richter <[email protected]>
@richtja richtja added this to the 109 - Codename TBD milestone Oct 29, 2024
@richtja richtja self-assigned this Oct 29, 2024
Copy link
Contributor

@clebergnu clebergnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@clebergnu clebergnu merged commit b58d392 into avocado-framework:master Oct 29, 2024
52 of 59 checks passed
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.48%. Comparing base (f8537a5) to head (fe11714).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6055      +/-   ##
==========================================
+ Coverage   54.42%   54.48%   +0.06%     
==========================================
  Files         202      202              
  Lines       21885    21885              
==========================================
+ Hits        11911    11925      +14     
+ Misses       9974     9960      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richtja richtja deleted the codeclimate_removal branch October 30, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 109
Development

Successfully merging this pull request may close these issues.

3 participants