selftests/unit/utils/cpu.py: support the context manager pattern #6056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current mock method on the two tests modified here do not support the context manager pattern. Let's use the standard library support for mocking open that supports it. This is needed for future lint check improvements that will enforce the use of open() as a context manager to avoid leaking resources. The test_set_idle_state_withsetstate() test has a significant change of behavior: one io.BytesIO instance was used for the writes that, in real life, would happen on two different files. The proposed change brings a more realistic, with a single write to a single file (although it only checks half of the values now). Still, I believe this is an improvement, including the extra check for the file that was actually written to. Reference: https://docs.python.org/3/library/unittest.mock.html#mock-open Signed-off-by: Cleber Rosa <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6056 +/- ##
==========================================
- Coverage 54.48% 54.45% -0.04%
==========================================
Files 202 202
Lines 21885 21885
==========================================
- Hits 11925 11917 -8
- Misses 9960 9968 +8 ☔ View full report in Codecov by Sentry. |
richtja
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current mock method on the two tests modified here do not support the context manager pattern. Let's use the standard library support for mocking open that supports it.
This is needed for future lint check improvements that will enforce the use of open() as a context manager to avoid leaking resources.
The test_set_idle_state_withsetstate() test has a significant change of behavior: one io.BytesIO instance was used for the writes that, in real life, would happen on two different files. The proposed change brings a more realistic, with a single write to a single file (although it only checks half of the values now). Still, I believe this is an improvement, including the extra check for the file that was actually written to.
Reference: https://docs.python.org/3/library/unittest.mock.html#mock-open