Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GHC 9.4 #71

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Support GHC 9.4 #71

merged 4 commits into from
Nov 21, 2023

Conversation

j6carey
Copy link
Contributor

@j6carey j6carey commented Nov 19, 2023

Also support various dependencies and upgrade nixpkgs.

Also support various dependencies and upgrade nixpkgs.
@j6carey j6carey requested a review from riz0id November 19, 2023 02:54
Copy link
Contributor

@Friede80 Friede80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this work!

nix/overlays/haskell.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
grpc-mqtt.cabal Outdated Show resolved Hide resolved
@j6carey
Copy link
Contributor Author

j6carey commented Nov 21, 2023

@riz0id , @Friede80 , I'm fine with this being merged. But for me the "Squash and merge" button is greyed out for some reason.

@ixmatus
Copy link
Contributor

ixmatus commented Nov 21, 2023

@j6carey it's because we have a merge requirement on the repo that all commits be signed. I don't think that needs to be so hard and fast so I'll go ahead and merge it for you.

@ixmatus ixmatus merged commit 780aee3 into main Nov 21, 2023
1 check passed
@ixmatus ixmatus deleted the jcarey/ghc94 branch November 21, 2023 16:27
@ixmatus ixmatus restored the jcarey/ghc94 branch November 21, 2023 16:27
@j6carey
Copy link
Contributor Author

j6carey commented Nov 21, 2023

@ixmatus , thanks. Let me know if I should be signing commits in future.

@j6carey j6carey deleted the jcarey/ghc94 branch November 21, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants