Remove unused code blocks for Bedrock Agent instrumentation #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The initial instrumentation for Bedrock Agent was intended to extract only one attribute per operation, despite cases where two or more attributes exist in the request or response bodies. To implement this, we created
OperationNameToResourceMapto associate each Bedrock Agent function with exactly one attribute.However, the recently added CFN Primary Identifier attribute contains a special case for data source operations, for which the identifier has format:
<KnowledgeBaseId>|<DataSourceId>(see #142). Because both attributes are needed in order to form the CFN Primary ID, the previous one-attribute restriction was lifted and the Bedrock Agent-specific logic for attribute extraction was no longer needed. This PR removes the obsolete functions and structures that are no longer utilized after the implementation of the CFN Primary ID.The E2E test result below provides a sanity check that a given Bedrock Agent operation can extract multiple
aws.bedrock.*attributes and does not rely on the deleted code.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.