Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validator to cover ADOT v2 version. #1724

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

zzhlogin
Copy link
Contributor

Description:
ADOT Java right now support V2.x version which utilize otel upstream latest v2.10.0 (PR). The e2e test failed because the trace template is not updated to match with v2.x versions: https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/12486110016/job/34846031564

This PR update the trace validator template to match the emitted trace for both v1.x and v2.x versions.

Testing:
Local generate a new image using the updated code, and confirmed the tests passed successfully:

validator-1  | 22:34:49.547 [main] INFO  com.amazon.aoc.validators.TraceValidator - validation is passed for path /aws-sdk-call
validator-1  | 22:34:49.547 [main] INFO  com.amazon.aoc.App - Validation has completed in 1 minutes.
app-1        | [otel.javaagent 2024-12-24 22:34:49:578 +0000] [qtp1006917610-65] DEBUG io.opentelemetry.javaagent.tooling.AgentInstaller$TransformLoggingListener - Transformed org.eclipse.jetty.io.ManagedSelector$DestroyEndPoint -- jdk.internal.loader.ClassLoaders$AppClassLoader@1dbd16a6
validator-1 exited with code 0
Aborting on container exit...
[+] Stopping 3/3
 ✔ Container collector-validator-1  Stop...                                   0.0s
 ✔ Container collector-otel-1       Stopped                                   0.6s
 ✔ Container collector-app-1        Stopped                                   5.9s

Documentation:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zzhlogin zzhlogin requested a review from a team as a code owner December 24, 2024 22:38
@vasireddy99 vasireddy99 merged commit 3985f1e into aws-observability:terraform Dec 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants