feat: Ignore file not exists error when delete files in KB #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konokenj
requested review from
statefb,
wadabee and
Yukinobu-Mine
as code owners
|
Note: users already had an S3 bucket containing over 1,000 files that we wanted to copy files from. Currently, to initialize a KB, they need to upload at least one dummy file through the UI (this is another UX point we may want to improve - allowing creation of empty KBs). After copying files directly in S3, we wanted to clean up by removing that initial dummy file from the DB, but it was already deleted from S3. This is why ignoring the "file not exists" error would be helpful in this scenario. |
statefb
reviewed
Jan 15, 2025
|
Thank you for your feedback! I added some comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #662
Description of changes:
Ignore
The file does not exist in bucketerror when deleting a file from S3 bucket for knowledge bases. This makes users to be able to update bot if the uploaded file has gone after bot created.Rather than removing the check logic, I added a flag. If there is a reason why you raise this error intentionally, please let me know.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.