Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark theme #676

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Add dark theme #676

merged 3 commits into from
Jan 16, 2025

Conversation

nagineko
Copy link
Contributor

@nagineko nagineko commented Jan 4, 2025

Issue #, if available:
#10

Description of changes:

  • Added color code for dark theme.
  • Use local storage and add logic to apply dark theme.
  • Added a toggle button in the upper left corner of the chat page to switch between dark and light themes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@nagineko nagineko marked this pull request as draft January 4, 2025 18:08
@nagineko nagineko marked this pull request as ready for review January 4, 2025 18:09
@Yukinobu-Mine
Copy link
Contributor

@nagineko PRありがとうございます!1点コメントさせて頂きましたので、ご確認いただけますでしょうか?

@Yukinobu-Mine
Copy link
Contributor

Yukinobu-Mine commented Jan 9, 2025

@nagineko 一通り動作確認させて頂きました。以下の2点の修正をお願いできますでしょうか?

  1. テーマ切り替えのトグルを ChatPage ではなく、左ペイン (ChatListDrawer) の「Menu」ボタンと同じ行の右端に配置
  2. Ladle によるコンポーネントのプレビュー表示で、左下の「Switch to dark theme」を押してもコンポーネントがダークモード表示に切り替わらない

@nagineko
Copy link
Contributor Author

nagineko commented Jan 9, 2025

@Yukinobu-Mine
テーマ切り替えトグルをMenuボタンの右側に、Ladleでの表示対応を行いました。
ご確認のほどお願いします。

@Yukinobu-Mine
Copy link
Contributor

@nagineko 修正対応ありがとうございます!Ladle でのダークモード表示について1点コメントしましたので、ご確認頂けますでしょうか?

Copy link
Contributor

@Yukinobu-Mine Yukinobu-Mine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@statefb statefb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you for your contribution!

@Yukinobu-Mine Yukinobu-Mine merged commit 644a3a2 into aws-samples:v2 Jan 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants