Add resource metric integration test #453
Open
+149
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varunch77
changed the title
varunch77
commented
Jan 17, 2025
lisguo
reviewed
Jan 22, 2025
|
Changes:
|
zhihonl
reviewed
Jan 24, 2025
| common.StopAgent() | ||
|
|
||
| // build ListEntitiesForMetric request: | ||
| requestBody := []byte(fmt.Sprintf(`{ |
There was a problem hiding this comment.
nit: I think would be nice to turn these into test case input, then in the future if someone else to implement a new test, they can just write an additional case instead of copying this entire boilerplate code. For example: https://github.com/aws/amazon-cloudwatch-agent-test/pull/453/files#diff-13510c6aa10605c1f76162fde322c3a4da1cf75441a3a93cb340fbb9d36c480dR186
|
Can you attach a new integration test run with this change so we can make sure the test still passes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
There is no integration test that verifies that an entity is being sent when we send resource metrics such as cpu and memory to CloudWatch—this is currently a gap in our testing.
Description of changes
ListEntitiesForMetricto get the entity associated with our metricsListEntitiesForMetricLicense
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Integration test run: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/12838570212