Remove unnecessary LIST calls for k8s pods #1492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Davanum Srinivas <[email protected]>
dims
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
We are see the following Global list pod request served from cache by amazon-cloudwatch-agent daemonset
On a large cluster with lots of pods, there is a huge cost for the kubernetes api server to serve this request from amazon-cloudwatch-agent.
Description of changes
Since it's not entirely clear if the information being requested is even needed anywhere in the codebase, filing this PR to check if any of the CI jobs fail
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Ran various unit tests in the repository.
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lintDONE! (both steps 1 and 2)