update telegraf module for disk usage metrics fix on macOS #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mann
approved these changes
Jan 13, 2025
jefchien
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
The commit SHA in the version looks correct. aws/telegraf@a2dfaa4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
There is an issue in scraping disk usage on macOS systems. The problem stems from gopsutil's reliance on unix.Statfs, which is not accurately retrieving disk usage data on macOS. While unix.Statfs is generally reliable on many Unix systems, it seems to be incompatible with macOS's specific filesystem (APFS) implementation or reporting mechanisms. This leads to inaccurate disk usage metrics (where all reported mount points have same used space values), impacting macOS customers' observability to their resources.
Description of changes
PR in aws/telegraf aws/telegraf#167
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Test results aws/telegraf#167
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint