Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMF Exporter does not forward metrics if IRSA is enabled #915

Merged
merged 14 commits into from
Oct 23, 2023
Merged

Conversation

dchappa
Copy link
Contributor

@dchappa dchappa commented Oct 20, 2023

Description of the issue

If a customer is using EMF along with IRSA, customer metrics would not be forwarded to the configured account.

Description of changes

The EMF exporter translator was missing a statement to pass the RoleARN component from the agent configuration.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Tested on personal cluster, sucessfully forwarded logs/metrics the configured secondary account.

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

SaxyPandaBear
SaxyPandaBear previously approved these changes Oct 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (96d4763) 57.58% compared to head (4228271) 62.41%.
Report is 431 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
+ Coverage   57.58%   62.41%   +4.83%     
==========================================
  Files         370      339      -31     
  Lines       17548    17140     -408     
==========================================
+ Hits        10105    10698     +593     
+ Misses       6848     5886     -962     
+ Partials      595      556      -39     
Files Coverage Δ
cfg/commonconfig/commonconfig.go 8.00% <ø> (ø)
...md/amazon-cloudwatch-agent-config-wizard/wizard.go 59.55% <ø> (-8.51%) ⬇️
...amazon-cloudwatch-agent/amazon-cloudwatch-agent.go 2.64% <ø> (ø)
...oudwatch-agent/register_event_logger_notwindows.go 0.00% <ø> (ø)
...-cloudwatch-agent/register_event_logger_windows.go 0.00% <ø> (ø)
cmd/config-translator/translator.go 0.00% <ø> (ø)
cmd/xray-migration/commands_unix.go 42.50% <ø> (ø)
cmd/xray-migration/commands_windows.go 42.50% <ø> (ø)
cmd/xray-migration/xray-migration.go 30.28% <ø> (ø)
handlers/agentinfo/info.go 84.94% <ø> (ø)
... and 22 more

... and 207 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

adam-mateen
adam-mateen previously approved these changes Oct 20, 2023
@dchappa dchappa requested a review from adam-mateen October 23, 2023 17:12
SaxyPandaBear
SaxyPandaBear previously approved these changes Oct 23, 2023
@dchappa dchappa requested a review from SaxyPandaBear October 23, 2023 19:21
@adam-mateen adam-mateen merged commit b6c6bfa into main Oct 23, 2023
6 checks passed
@adam-mateen adam-mateen deleted the irsaIssue branch October 23, 2023 20:05
lisguo pushed a commit to lisguo/amazon-cloudwatch-agent that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IRSA forwarding of metrics to other aws accounts does not work in latest version of cloudwatch agent
4 participants