Support for suppressible Chat license acknowledgement #316
+31
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedloj
force-pushed
the
breedloj/licenseSuppression
branch
2 times, most recently
from
b61f313 to
089284f
Compare
breedloj
force-pushed
the
breedloj/licenseSuppression
branch
from
089284f to
7d36019
Compare
shruti0085
approved these changes
Jan 9, 2025
| @@ -45,7 +45,7 @@ public QLspConnectionProvider() throws IOException { | |||
| protected final void addEnvironmentVariables(final Map<String, String> env) { | |||
| String httpsProxyPreference = Activator.getDefault().getPreferenceStore().getString(AmazonQPreferencePage.HTTPS_PROXY); | |||
| String caCertPreference = Activator.getDefault().getPreferenceStore().getString(AmazonQPreferencePage.CA_CERT); | |||
| if (!StringUtils.isEmpty(caCertPreference)) { | |||
| if (!StringUtils.isEmpty(httpsProxyPreference)) { | |||
| @@ -117,6 +117,9 @@ public final void handleCommand(final ParsedCommand parsedCommand, final Browser | |||
| AuthFollowUpClickedParams authFollowUpClickedParams = jsonHandler.convertObject(params, AuthFollowUpClickedParams.class); | |||
| handleAuthFollowUpClicked(authFollowUpClickedParams); | |||
| break; | |||
| case DISCLAIMER_ACKNOWLEDGED: | |||
| Activator.getPluginStore().put(PluginStoreKeys.CHAT_DISCLAIMER_ACKNOWLEDGED, "true"); | |||
There was a problem hiding this comment.
in what condition would this be set to a false?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds support for the suppressible Chat license acknowledgement in the Q Chat UI. Upon acknowledgement the setting is persisted by the extension and passed to Mynah via init calls.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.