-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cli): collate existing files into new deployments api #33094
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/33094/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed, add Clarification Request
to a comment.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #33094 +/- ##
==========================================
+ Coverage 81.51% 81.52% +0.01%
==========================================
Files 223 225 +2
Lines 13752 13760 +8
Branches 2413 2413
==========================================
+ Hits 11210 11218 +8
Misses 2270 2270
Partials 272 272
Flags with carried forward coverage won't be shown. Click here to find out more.
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
Cleaning up the CLI code base in preparation for splitting out the library parts.
It's currently quite hard to reason about the existing api code as its spread across many files and deep subpath imports.
This change attempts to partly rectify the situation by grouping files with strong interdependencies together and creating a unified import location.
The change deliberately gives up on potential feature reusability of some helpers in order to create locality.
Description of changes
Collating existing files and APIs into a new submodule
api/deployments
.Updated imports accordingly.
No functional changes.
Describe any new or updated permissions being added
n/a
Description of how you validated changes
exiting tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license