Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): collate existing files into new deployments api #33094

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Jan 23, 2025

Reason for this change

Cleaning up the CLI code base in preparation for splitting out the library parts.
It's currently quite hard to reason about the existing api code as its spread across many files and deep subpath imports.
This change attempts to partly rectify the situation by grouping files with strong interdependencies together and creating a unified import location.
The change deliberately gives up on potential feature reusability of some helpers in order to create locality.

Description of changes

Collating existing files and APIs into a new submodule api/deployments.
Updated imports accordingly.
No functional changes.

Describe any new or updated permissions being added

n/a

Description of how you validated changes

exiting tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain requested a review from a team as a code owner January 23, 2025 12:56
@aws-cdk-automation aws-cdk-automation requested a review from a team January 23, 2025 12:57
@github-actions github-actions bot added the p2 label Jan 23, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 23, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/33094/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 97.22222% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.52%. Comparing base (8506d31) to head (2f0d775).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #33094      +/-   ##
==========================================
+ Coverage   81.51%   81.52%   +0.01%     
==========================================
  Files         223      225       +2     
  Lines       13752    13760       +8     
  Branches     2413     2413              
==========================================
+ Hits        11210    11218       +8     
  Misses       2270     2270              
  Partials      272      272              
Flag Coverage Δ
suite.unit 81.52% <97.22%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.92% <97.22%> (+0.02%) ⬆️
packages/aws-cdk-lib/core 82.15% <ø> (ø)

@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2f0d775
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mrgrain mrgrain added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Jan 23, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 23, 2025 16:27

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Jan 23, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ac90399 into main Jan 23, 2025
25 of 26 checks passed
@mergify mergify bot deleted the mrgrain/refactor/cli-cleanups branch January 23, 2025 16:28
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants