-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make PR linter overwrite previous reviews and delete old comments #33105
Conversation
Many changes here: - The PR linter now removes the text of previous reviews, so that they are not distracting. - The PR linter now deletes old comments; before the rewrite, it used to create both comments and reviews. The comments should be deleted. - There were a bunch of missing `await`s, add those. - The missing `await`s slipped in because in the past someone tried to turn off *some* linter rules, and in doing so disabled *all* linter rules. For now, just re-enable the ones that have to do with promises.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33105 +/- ##
=======================================
Coverage 81.54% 81.54%
=======================================
Files 226 226
Lines 13777 13777
Branches 2414 2414
=======================================
Hits 11235 11235
Misses 2270 2270
Partials 272 272
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Many changes here:
await
s, add those.await
s slipped in because in the past someone tried to turn off some linter rules, and in doing so disabled all linter rules. For now, just re-enable the ones that have to do with promises.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license