Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make PR linter overwrite previous reviews and delete old comments #33105

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jan 23, 2025

Many changes here:

  • The PR linter now removes the text of previous reviews, so that they are not distracting.
  • The PR linter now deletes old comments; before the rewrite, it used to create both comments and reviews. The comments should be deleted.
  • There were a bunch of missing awaits, add those.
  • The missing awaits slipped in because in the past someone tried to turn off some linter rules, and in doing so disabled all linter rules. For now, just re-enable the ones that have to do with promises.
  • Fix a typo in a global constant
  • Only log the relevant details of reviews, instead of the entire GitHub object

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Many changes here:

- The PR linter now removes the text of previous reviews, so that they
  are not distracting.
- The PR linter now deletes old comments; before the rewrite, it used
  to create both comments and reviews. The comments should be deleted.
- There were a bunch of missing `await`s, add those.
- The missing `await`s slipped in because in the past someone tried
  to turn off *some* linter rules, and in doing so disabled *all*
  linter rules. For now, just re-enable the ones that have to do
  with promises.
@rix0rrr rix0rrr requested a review from a team January 23, 2025 20:22
@github-actions github-actions bot added the p2 label Jan 23, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 23, 2025 20:22
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.54%. Comparing base (809a7f0) to head (6e58fc9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33105   +/-   ##
=======================================
  Coverage   81.54%   81.54%           
=======================================
  Files         226      226           
  Lines       13777    13777           
  Branches     2414     2414           
=======================================
  Hits        11235    11235           
  Misses       2270     2270           
  Partials      272      272           
Flag Coverage Δ
suite.unit 81.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.94% <ø> (ø)
packages/aws-cdk-lib/core 82.17% <ø> (ø)

Copy link
Contributor

mergify bot commented Jan 23, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6e58fc9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jan 23, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7b9f6c8 into main Jan 23, 2025
20 checks passed
@mergify mergify bot deleted the huijbers/linter-comments branch January 23, 2025 22:17
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants