Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Update integration tests to test against the new --on-failure exit code #6370

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

lucashuy
Copy link
Contributor

@lucashuy lucashuy commented Nov 30, 2023

Which issue(s) does this change fix?

None.

Why is this change necessary?

Recent change was made to --on-failure's behaviour so that the exit code represents the status of the deployment, not the status of command execution. This causes the integration tests to fail since they were not updated.

How does it address the issue?

Updates our tests to check for exit code 1 for the command runs that attempt to deploy a broken stack.

What side effects does this change have?

None.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lucashuy lucashuy requested a review from a team as a code owner November 30, 2023 18:55
@lucashuy lucashuy added this pull request to the merge queue Nov 30, 2023
Merged via the queue into aws:develop with commit 7071cb5 Nov 30, 2023
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants