-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
telemetry(amazonq): attach stack trace in onCodeGeneration failures #6293
base: master
Are you sure you want to change the base?
Conversation
packages/core/src/test/amazonqFeatureDev/controllers/chat/controller.test.ts
Outdated
Show resolved
Hide resolved
912dfce
to
3b41c98
Compare
3b41c98
to
33a1006
Compare
packages/core/src/amazonqFeatureDev/controllers/chat/controller.ts
Outdated
Show resolved
Hide resolved
packages/core/src/test/amazonqFeatureDev/controllers/chat/controller.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is lacking an acceptable explanation of what the purpose is, and how it works. Did you test this with a production webpack'd build? Nodejs stacktraces in the production build are usually obfuscated.
The docstring of the function does not give useful insights.
The function is non-trivial, and has no test coverage.
Assuming the function works, it belongs in a core util module, not randomly in the middle of a feature module.
Problem
To further find issues in onCodeGeneration, need to attach stack trace when sending metrics
Solution
Attach stack trace when sending metrics
feature/x
branches will not be squash-merged at release time.