Fix warning message condition for subsegment ending

aws · May 29, 2024 · e62f0c5 · e62f0c5
1 parent e65d05b
commit e62f0c5
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/aws_xray_sdk/core/context.py b/aws_xray_sdk/core/context.py
@@ -78,11 +78,13 @@ def end_subsegment(self, end_time=None):
         :param float end_time: epoch in seconds. If not specified the current
             system time will be used.
         """
-        subsegment = self.get_trace_entity()
-        if self._is_subsegment(subsegment):
-            subsegment.close(end_time)
+        entity = self.get_trace_entity()
+        if self._is_subsegment(entity):
+            entity.close(end_time)
             self._local.entities.pop()
             return True
+        elif isinstance(entity, DummySegment):
+            return False
         else:
             log.warning("No subsegment to end.")
             return False