-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --split-queries option to export-pg-from-queries #105
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #105 +/- ##
===========================================
+ Coverage 44.81% 45.53% +0.71%
===========================================
Files 247 248 +1
Lines 8550 8618 +68
Branches 881 893 +12
===========================================
+ Hits 3832 3924 +92
+ Misses 4423 4392 -31
- Partials 295 302 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One minor comment.
Do we have any performance data on how using --split-queries improves compared to not using it? Is there caveat with using this option that we should highlight in the docs? I.e. "recommended to use this for xxx"?
I think you've added great features and many new options, so it might be helpful to have a section of the docs that gives pointer to why and how to use them.
I will add some additional documentation to appropriate sections of the readme. |
Issue #, if available: N/A
Description of changes:
Add a new --split-queries CLI arg to queries exports which inject
range()
steps into the start of queries according to a RangeConfig and ConcurrencyConfig in order to run queries concurrently.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.