Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --split-queries option to export-pg-from-queries #105

Merged
merged 8 commits into from
Dec 21, 2023

Conversation

Cole-Greer
Copy link
Collaborator

@Cole-Greer Cole-Greer commented Dec 14, 2023

Issue #, if available: N/A

Description of changes:

Add a new --split-queries CLI arg to queries exports which inject range() steps into the start of queries according to a RangeConfig and ConcurrencyConfig in order to run queries concurrently.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (f20eaf1) 44.81% compared to head (3589cf1) 45.53%.

Files Patch % Lines
...neptune/ExportPropertyGraphFromGremlinQueries.java 0.00% 7 Missing ⚠️
...propertygraph/LazyQueriesRangeFactoryProvider.java 80.00% 4 Missing and 2 partials ⚠️
...s/services/neptune/propertygraph/NamedQueries.java 87.50% 0 Missing and 3 partials ⚠️
...ws/services/neptune/propertygraph/EdgesClient.java 0.00% 1 Missing and 1 partial ⚠️
...ws/services/neptune/propertygraph/NodesClient.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #105      +/-   ##
===========================================
+ Coverage    44.81%   45.53%   +0.71%     
===========================================
  Files          247      248       +1     
  Lines         8550     8618      +68     
  Branches       881      893      +12     
===========================================
+ Hits          3832     3924      +92     
+ Misses        4423     4392      -31     
- Partials       295      302       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cole-Greer Cole-Greer marked this pull request as ready for review December 19, 2023 00:27
Copy link

@vkagamlyk vkagamlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@xiazcy xiazcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor comment.
Do we have any performance data on how using --split-queries improves compared to not using it? Is there caveat with using this option that we should highlight in the docs? I.e. "recommended to use this for xxx"?
I think you've added great features and many new options, so it might be helpful to have a section of the docs that gives pointer to why and how to use them.

@Cole-Greer
Copy link
Collaborator Author

LGTM. One minor comment. Do we have any performance data on how using --split-queries improves compared to not using it? Is there caveat with using this option that we should highlight in the docs? I.e. "recommended to use this for xxx"? I think you've added great features and many new options, so it might be helpful to have a section of the docs that gives pointer to why and how to use them.

I will add some additional documentation to appropriate sections of the readme.

@Cole-Greer Cole-Greer merged commit d7fede4 into develop Dec 21, 2023
3 checks passed
@Cole-Greer Cole-Greer deleted the split-queries branch November 20, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants