-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add sslv2 client hello test w/ jvm #5019
Conversation
c379913
to
c632724
Compare
* add stdout assertion
wow, running it locally is so nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corretto 17 doesn't like this...
Command line: java -classpath bin SSLSocketClient 8002 ../pems/rsa_2048_sha256_client_cert.pem TLS_RSA_WITH_AES_256_CBC_SHA256 TLS1.2 S S L v 2 H e l l o
Exit code: 0
Stdout:
Stderr: java.lang.IllegalArgumentException: Unsupported protocolS
at java.base/sun.security.ssl.ProtocolVersion.namesOf(ProtocolVersion.java:292)
at java.base/sun.security.ssl.SSLSocketImpl.setEnabledProtocols(SSLSocketImpl.java:361)
at SSLSocketClient.main(SSLSocketClient.java:38)
Which jdk are you using/expecting ? and do we need a way to account for max(java --version) ?
Perhaps in CI autopep8 has a different config that it reads from? But whenever I try and run it it changes a whole bunch of unrelated lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
passes locally on my arm nix host 👍
* rely on existing ClientHello debugging message * stricter parsing of protocol version * document protocol assumptions
Co-authored-by: Lindsay Stewart <[email protected]>
Description of changes:
Based on feedback from #5011 , this PR instead adds an SSLv2 integration using the
integrationv2
style.Testing:
I examined the ClientHello with wireshark and added a debug statement to confirm that the ClientHello that the java client was sending was ClientHello SSLv2.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.