feat: support default checksums

.github/workflows/continuous-integration.yml

@@ -40,6 +40,12 @@ jobs:
           pwd
           ls -lsa
           ./gradlew -Ptest.java.version=${{ matrix.java-version }} jvmTest --stacktrace
+      - name: Save Test Reports
+        if: failure()
+        uses: actions/upload-artifact@v3
+        with:
+          name: test-reports
+          path: '**/build/reports'
 
   all-platforms:
     runs-on: ${{ matrix.os }}

aws-runtime/aws-config/api/aws-config.api

@@ -243,7 +243,9 @@ public final class aws/sdk/kotlin/runtime/config/AwsSdkSetting {
 	public final fun getAwsMaxAttempts ()Laws/smithy/kotlin/runtime/config/EnvironmentSetting;
 	public final fun getAwsProfile ()Laws/smithy/kotlin/runtime/config/EnvironmentSetting;
 	public final fun getAwsRegion ()Laws/smithy/kotlin/runtime/config/EnvironmentSetting;
+	public final fun getAwsRequestChecksumCalculation ()Laws/smithy/kotlin/runtime/config/EnvironmentSetting;
 	public final fun getAwsRequestMinCompressionSizeBytes ()Laws/smithy/kotlin/runtime/config/EnvironmentSetting;
+	public final fun getAwsResponseChecksumValidation ()Laws/smithy/kotlin/runtime/config/EnvironmentSetting;
 	public final fun getAwsRetryMode ()Laws/smithy/kotlin/runtime/config/EnvironmentSetting;
 	public final fun getAwsRoleArn ()Laws/smithy/kotlin/runtime/config/EnvironmentSetting;
 	public final fun getAwsRoleSessionName ()Laws/smithy/kotlin/runtime/config/EnvironmentSetting;
@@ -260,6 +262,13 @@ public final class aws/sdk/kotlin/runtime/config/AwsSdkSettingKt {
 	public static final fun resolveEndpointUrl (Laws/sdk/kotlin/runtime/config/AwsSdkSetting;Laws/smithy/kotlin/runtime/util/PlatformProvider;Ljava/lang/String;Ljava/lang/String;)Laws/smithy/kotlin/runtime/net/url/Url;
 }
 
+public final class aws/sdk/kotlin/runtime/config/checksums/ResolveFlexibleChecksumsConfigKt {
+	public static final fun resolveRequestChecksumCalculation (Laws/smithy/kotlin/runtime/util/PlatformProvider;Laws/smithy/kotlin/runtime/util/LazyAsyncValue;Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
+	public static synthetic fun resolveRequestChecksumCalculation$default (Laws/smithy/kotlin/runtime/util/PlatformProvider;Laws/smithy/kotlin/runtime/util/LazyAsyncValue;Lkotlin/coroutines/Continuation;ILjava/lang/Object;)Ljava/lang/Object;
+	public static final fun resolveResponseChecksumValidation (Laws/smithy/kotlin/runtime/util/PlatformProvider;Laws/smithy/kotlin/runtime/util/LazyAsyncValue;Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
+	public static synthetic fun resolveResponseChecksumValidation$default (Laws/smithy/kotlin/runtime/util/PlatformProvider;Laws/smithy/kotlin/runtime/util/LazyAsyncValue;Lkotlin/coroutines/Continuation;ILjava/lang/Object;)Ljava/lang/Object;
+}
+
 public final class aws/sdk/kotlin/runtime/config/compression/RequestCompressionResolversKt {
 	public static final fun resolveDisableRequestCompression (Laws/smithy/kotlin/runtime/util/PlatformProvider;Laws/smithy/kotlin/runtime/util/LazyAsyncValue;Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
 	public static synthetic fun resolveDisableRequestCompression$default (Laws/smithy/kotlin/runtime/util/PlatformProvider;Laws/smithy/kotlin/runtime/util/LazyAsyncValue;Lkotlin/coroutines/Continuation;ILjava/lang/Object;)Ljava/lang/Object;
@@ -467,7 +476,9 @@ public final class aws/sdk/kotlin/runtime/config/profile/AwsProfileKt {
 	public static synthetic fun getLongOrNull$default (Laws/sdk/kotlin/runtime/config/profile/ConfigSection;Ljava/lang/String;Ljava/lang/String;ILjava/lang/Object;)Ljava/lang/Long;
 	public static final fun getMaxAttempts (Laws/sdk/kotlin/runtime/config/profile/ConfigSection;)Ljava/lang/Integer;
 	public static final fun getRegion (Laws/sdk/kotlin/runtime/config/profile/ConfigSection;)Ljava/lang/String;
+	public static final fun getRequestChecksumCalculation (Laws/sdk/kotlin/runtime/config/profile/ConfigSection;)Laws/smithy/kotlin/runtime/client/config/RequestHttpChecksumConfig;
 	public static final fun getRequestMinCompressionSizeBytes (Laws/sdk/kotlin/runtime/config/profile/ConfigSection;)Ljava/lang/Long;
+	public static final fun getResponseChecksumValidation (Laws/sdk/kotlin/runtime/config/profile/ConfigSection;)Laws/smithy/kotlin/runtime/client/config/ResponseHttpChecksumConfig;
 	public static final fun getRetryMode (Laws/sdk/kotlin/runtime/config/profile/ConfigSection;)Laws/smithy/kotlin/runtime/client/config/RetryMode;
 	public static final fun getRoleArn (Laws/sdk/kotlin/runtime/config/profile/ConfigSection;)Ljava/lang/String;
 	public static final fun getSdkUserAgentAppId (Laws/sdk/kotlin/runtime/config/profile/ConfigSection;)Ljava/lang/String;

aws-runtime/aws-config/common/src/aws/sdk/kotlin/runtime/config/AbstractAwsSdkClientFactory.kt

@@ -6,6 +6,8 @@
 package aws.sdk.kotlin.runtime.config
 
 import aws.sdk.kotlin.runtime.client.AwsSdkClientConfig
+import aws.sdk.kotlin.runtime.config.checksums.resolveRequestChecksumCalculation
+import aws.sdk.kotlin.runtime.config.checksums.resolveResponseChecksumValidation
 import aws.sdk.kotlin.runtime.config.compression.resolveDisableRequestCompression
 import aws.sdk.kotlin.runtime.config.compression.resolveRequestMinCompressionSizeBytes
 import aws.sdk.kotlin.runtime.config.endpoints.resolveUseDualStack
@@ -22,6 +24,7 @@ import aws.smithy.kotlin.runtime.auth.awscredentials.SigV4aClientConfig
 import aws.smithy.kotlin.runtime.client.*
 import aws.smithy.kotlin.runtime.client.config.ClientSettings
 import aws.smithy.kotlin.runtime.client.config.CompressionClientConfig
+import aws.smithy.kotlin.runtime.client.config.HttpChecksumConfig
 import aws.smithy.kotlin.runtime.config.resolve
 import aws.smithy.kotlin.runtime.telemetry.TelemetryConfig
 import aws.smithy.kotlin.runtime.telemetry.TelemetryProvider
@@ -94,6 +97,14 @@ public abstract class AbstractAwsSdkClientFactory<
                     config.sigV4aSigningRegionSet ?: resolveSigV4aSigningRegionSet(platform, profile)
             }
 
+            if (config is HttpChecksumConfig.Builder) {
+                config.requestChecksumCalculation =
+                    config.requestChecksumCalculation ?: resolveRequestChecksumCalculation(platform, profile)
+
+                config.responseChecksumValidation =
+                    config.responseChecksumValidation ?: resolveResponseChecksumValidation(platform, profile)
+            }
+
             finalizeConfig(builder)
             finalizeEnvironmentalConfig(builder, sharedConfig, profile)
         }

aws-runtime/aws-config/common/src/aws/sdk/kotlin/runtime/config/AwsSdkSetting.kt

@@ -9,6 +9,8 @@ import aws.sdk.kotlin.runtime.InternalSdkApi
 import aws.sdk.kotlin.runtime.config.endpoints.AccountIdEndpointMode
 import aws.sdk.kotlin.runtime.http.AWS_APP_ID_ENV
 import aws.sdk.kotlin.runtime.http.AWS_APP_ID_PROP
+import aws.smithy.kotlin.runtime.client.config.RequestHttpChecksumConfig
+import aws.smithy.kotlin.runtime.client.config.ResponseHttpChecksumConfig
 import aws.smithy.kotlin.runtime.client.config.RetryMode
 import aws.smithy.kotlin.runtime.config.*
 import aws.smithy.kotlin.runtime.net.url.Url
@@ -208,6 +210,18 @@ public object AwsSdkSetting {
      */
     public val AwsSigV4aSigningRegionSet: EnvironmentSetting<String> =
         strEnvSetting("aws.sigV4aSigningRegionSet", "AWS_SIGV4A_SIGNING_REGION_SET")
+
+    /**
+     * Configures request checksum calculation
+     */
+    public val AwsRequestChecksumCalculation: EnvironmentSetting<RequestHttpChecksumConfig> =
+        enumEnvSetting<RequestHttpChecksumConfig>("aws.requestChecksumCalculation", "AWS_REQUEST_CHECKSUM_CALCULATION")
+
+    /**
+     * Configures response checksum validation
+     */
+    public val AwsResponseChecksumValidation: EnvironmentSetting<ResponseHttpChecksumConfig> =
+        enumEnvSetting<ResponseHttpChecksumConfig>("aws.responseChecksumValidation", "AWS_RESPONSE_CHECKSUM_VALIDATION")
 }
 
 /**

aws-runtime/aws-config/common/src/aws/sdk/kotlin/runtime/config/checksums/ResolveFlexibleChecksumsConfig.kt

@@ -0,0 +1,34 @@
+package aws.sdk.kotlin.runtime.config.checksums
+
+import aws.sdk.kotlin.runtime.InternalSdkApi
+import aws.sdk.kotlin.runtime.config.AwsSdkSetting
+import aws.sdk.kotlin.runtime.config.profile.AwsProfile
+import aws.sdk.kotlin.runtime.config.profile.requestChecksumCalculation
+import aws.sdk.kotlin.runtime.config.profile.responseChecksumValidation
+import aws.smithy.kotlin.runtime.client.config.RequestHttpChecksumConfig
+import aws.smithy.kotlin.runtime.client.config.ResponseHttpChecksumConfig
+import aws.smithy.kotlin.runtime.config.resolve
+import aws.smithy.kotlin.runtime.util.LazyAsyncValue
+import aws.smithy.kotlin.runtime.util.PlatformProvider
+
+/**
+ * Attempts to resolve requestChecksumCalculation from the specified sources.
+ * @return requestChecksumCalculation setting if found, the default value if not.
+ */
+@InternalSdkApi
+public suspend fun resolveRequestChecksumCalculation(
+    platform: PlatformProvider = PlatformProvider.System,
+    profile: LazyAsyncValue<AwsProfile>,
+): RequestHttpChecksumConfig =
+    AwsSdkSetting.AwsRequestChecksumCalculation.resolve(platform) ?: profile.get().requestChecksumCalculation ?: RequestHttpChecksumConfig.WHEN_SUPPORTED
+
+/**
+ * Attempts to resolve responseChecksumValidation from the specified sources.
+ * @return responseChecksumValidation setting if found, the default value if not.
+ */
+@InternalSdkApi
+public suspend fun resolveResponseChecksumValidation(
+    platform: PlatformProvider = PlatformProvider.System,
+    profile: LazyAsyncValue<AwsProfile>,
+): ResponseHttpChecksumConfig =
+    AwsSdkSetting.AwsResponseChecksumValidation.resolve(platform) ?: profile.get().responseChecksumValidation ?: ResponseHttpChecksumConfig.WHEN_SUPPORTED

aws-runtime/aws-config/common/src/aws/sdk/kotlin/runtime/config/profile/AwsProfile.kt

@@ -8,6 +8,8 @@ package aws.sdk.kotlin.runtime.config.profile
 import aws.sdk.kotlin.runtime.ConfigurationException
 import aws.sdk.kotlin.runtime.InternalSdkApi
 import aws.sdk.kotlin.runtime.config.endpoints.AccountIdEndpointMode
+import aws.smithy.kotlin.runtime.client.config.RequestHttpChecksumConfig
+import aws.smithy.kotlin.runtime.client.config.ResponseHttpChecksumConfig
 import aws.smithy.kotlin.runtime.client.config.RetryMode
 import aws.smithy.kotlin.runtime.net.url.Url
 
@@ -167,6 +169,20 @@ public val AwsProfile.requestMinCompressionSizeBytes: Long?
 public val AwsProfile.sigV4aSigningRegionSet: String?
     get() = getOrNull("sigv4a_signing_region_set")
 
+/**
+ * Configures request checksum calculation
+ */
+@InternalSdkApi
+public val AwsProfile.requestChecksumCalculation: RequestHttpChecksumConfig?
+    get() = getOrNull("request_checksum_calculation")?.parseRequestHttpChecksumConfig()
+
+/**
+ * Configures response checksum validation
+ */
+@InternalSdkApi
+public val AwsProfile.responseChecksumValidation: ResponseHttpChecksumConfig?
+    get() = getOrNull("response_checksum_validation")?.parseResponseHttpChecksumConfig()
+
 /**
  * Parse a config value as a boolean, ignoring case.
  */
@@ -200,6 +216,32 @@ public fun AwsProfile.getLongOrNull(key: String, subKey: String? = null): Long?
         )
     }
 
+/**
+ * Parse a string value as [ResponseHttpChecksumConfig]
+ */
+private fun String?.parseResponseHttpChecksumConfig(): ResponseHttpChecksumConfig? =
+    when (this?.uppercase()) {
+        null -> null
+        "WHEN_SUPPORTED" -> ResponseHttpChecksumConfig.WHEN_SUPPORTED
+        "WHEN_REQUIRED" -> ResponseHttpChecksumConfig.WHEN_REQUIRED
+        else -> throw ConfigurationException(
+            "'$this' is not a valid value for 'response_checksum_validation'. Valid values are: ${ResponseHttpChecksumConfig.entries}",
+        )
+    }
+
+/**
+ * Parse a string value as [RequestHttpChecksumConfig]
+ */
+private fun String?.parseRequestHttpChecksumConfig(): RequestHttpChecksumConfig? =
+    when (this?.uppercase()) {
+        null -> null
+        "WHEN_SUPPORTED" -> RequestHttpChecksumConfig.WHEN_SUPPORTED
+        "WHEN_REQUIRED" -> RequestHttpChecksumConfig.WHEN_REQUIRED
+        else -> throw ConfigurationException(
+            "'$this' is not a valid value for 'request_checksum_calculation'. Valid values are: ${RequestHttpChecksumConfig.entries}",
+        )
+    }
+
 internal fun AwsProfile.getUrlOrNull(key: String, subKey: String? = null): Url? =
     getOrNull(key, subKey)?.let {
         try {

aws-runtime/aws-http/api/aws-http.api

@@ -196,6 +196,11 @@ public final class aws/sdk/kotlin/runtime/http/interceptors/BusinessMetricsInter
 	public fun readBeforeTransmit (Laws/smithy/kotlin/runtime/client/ProtocolRequestInterceptorContext;)V
 }
 
+public final class aws/sdk/kotlin/runtime/http/interceptors/IgnoreCompositeFlexibleChecksumResponseInterceptor : aws/smithy/kotlin/runtime/http/interceptors/FlexibleChecksumsResponseInterceptor {
+	public fun <init> (ZLaws/smithy/kotlin/runtime/client/config/ResponseHttpChecksumConfig;)V
+	public fun ignoreChecksum (Ljava/lang/String;Laws/smithy/kotlin/runtime/telemetry/logging/Logger;)Z
+}
+
 public final class aws/sdk/kotlin/runtime/http/interceptors/UnsupportedSigningAlgorithmInterceptor : aws/smithy/kotlin/runtime/client/Interceptor {
 	public fun <init> ()V
 	public fun modifyBeforeAttemptCompletion-gIAlu-s (Laws/smithy/kotlin/runtime/client/ResponseInterceptorContext;Lkotlin/coroutines/Continuation;)Ljava/lang/Object;

aws-runtime/aws-http/common/src/aws/sdk/kotlin/runtime/http/interceptors/IgnoreCompositeFlexibleChecksumResponseInterceptor.kt

@@ -0,0 +1,30 @@
+package aws.sdk.kotlin.runtime.http.interceptors
+
+import aws.smithy.kotlin.runtime.client.config.ResponseHttpChecksumConfig
+import aws.smithy.kotlin.runtime.http.interceptors.FlexibleChecksumsResponseInterceptor
+import aws.smithy.kotlin.runtime.telemetry.logging.Logger
+
+/**
+ * Variant of the [FlexibleChecksumsResponseInterceptor] where composite checksums are not validated
+ */
+public class IgnoreCompositeFlexibleChecksumResponseInterceptor(
+    responseValidationRequired: Boolean,
+    responseChecksumValidation: ResponseHttpChecksumConfig?,
+) : FlexibleChecksumsResponseInterceptor(
+    responseValidationRequired,
+    responseChecksumValidation,
+) {
+    override fun ignoreChecksum(checksum: String, logger: Logger): Boolean =
+        checksum.isCompositeChecksum().also { compositeChecksum ->
+            if (compositeChecksum) logger.info { "Checksum validation was skipped because it was a composite checksum" }
+        }
+}
+
+/**
+ * Verifies if a checksum is composite.
+ */
+private fun String.isCompositeChecksum(): Boolean {
+    // Ends with "-#" where "#" is a number
+    val regex = Regex("-(\\d)+$")
+    return regex.containsMatchIn(this)
+}

buildSrc/build.gradle.kts

@@ -0,0 +1,7 @@
+plugins {
+    alias(libs.plugins.kotlin.jvm)
+}
+
+repositories {
+    mavenCentral()
+}

buildSrc/settings.gradle.kts

@@ -0,0 +1,7 @@
+dependencyResolutionManagement {
+    versionCatalogs {
+        create("libs") {
+            from(files("../gradle/libs.versions.toml"))
+        }
+    }
+}

buildSrc/src/main/kotlin/aws/sdk/kotlin/tests/codegen/CodegenTest.kt

@@ -0,0 +1,18 @@
+package aws.sdk.kotlin.tests.codegen
+
+/**
+ * An AWS SDK for Kotlin codegen test
+ */
+data class CodegenTest(
+    val name: String,
+    val model: Model,
+    val serviceShapeId: String,
+)
+
+/**
+ * A smithy model file
+ */
+data class Model(
+    val fileName: String,
+    val path: String = "src/test/resources/",
+)

codegen/aws-sdk-codegen/build.gradle.kts

@@ -30,6 +30,7 @@ dependencies {
     api(libs.smithy.protocol.test.traits)
     implementation(libs.smithy.aws.endpoints)
     implementation(libs.smithy.smoke.test.traits)
+    implementation(libs.smithy.kotlin.runtime.core)
 
     testImplementation(libs.junit.jupiter)
     testImplementation(libs.junit.jupiter.params)

codegen/aws-sdk-codegen/src/main/kotlin/aws/sdk/kotlin/codegen/AwsRuntimeTypes.kt

@@ -62,6 +62,7 @@ object AwsRuntimeTypes {
             val UnsupportedSigningAlgorithmInterceptor = symbol("UnsupportedSigningAlgorithmInterceptor")
             val BusinessMetricsInterceptor = symbol("BusinessMetricsInterceptor")
             val AwsBusinessMetric = symbol("AwsBusinessMetric")
+            val IgnoreCompositeFlexibleChecksumResponseInterceptor = symbol("IgnoreCompositeFlexibleChecksumResponseInterceptor")
         }
 
         object Retries {

codegen/aws-sdk-codegen/src/main/kotlin/aws/sdk/kotlin/codegen/PresignerGenerator.kt

@@ -13,9 +13,7 @@ import software.amazon.smithy.kotlin.codegen.integration.KotlinIntegration
 import software.amazon.smithy.kotlin.codegen.integration.SectionId
 import software.amazon.smithy.kotlin.codegen.integration.SectionKey
 import software.amazon.smithy.kotlin.codegen.lang.KotlinTypes
-import software.amazon.smithy.kotlin.codegen.model.buildSymbol
-import software.amazon.smithy.kotlin.codegen.model.expectShape
-import software.amazon.smithy.kotlin.codegen.model.getTrait
+import software.amazon.smithy.kotlin.codegen.model.*
 import software.amazon.smithy.kotlin.codegen.model.knowledge.AwsSignatureVersion4
 import software.amazon.smithy.kotlin.codegen.rendering.endpoints.EndpointResolverAdapterGenerator
 import software.amazon.smithy.kotlin.codegen.rendering.protocol.HttpBindingProtocolGenerator