Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add operational preferences support or stacksets customization (Continue) #622

Conversation

allcloud-sahar-hagbi
Copy link
Contributor

@allcloud-sahar-hagbi allcloud-sahar-hagbi commented Oct 28, 2024

This pr is dealing with adding support for specifying operational preferences option when deploying custom stacksets in customization-config.yml file.
This pr is a continue for this pr.

@erwaxler @mbevc1

Export operational preferences option when deploying custom stacksets

feat: add some fixes for operational preferences option

Adding some fixes for operatinal preferences option
@mbevc1
Copy link

mbevc1 commented Oct 28, 2024

Thanks, LGTM!

@allcloud-sahar-hagbi
Copy link
Contributor Author

allcloud-sahar-hagbi commented Oct 28, 2024

Hi, the CI is failing on this branch, which is weird because before the rebase from version v1.9.1 to version v1.10.0 it passed successfully.

I investigated the cause of why the CI is failing and it seems that the installer stack snapshot didn't get updated in release v1.10.0., the snapshot still points out on release v1.9.1.
The CI is failing on the snapshot source/packages/@aws-accelerator/installer/test/__snapshots__/installer.test.ts.snap which contains remnants of release v1.9.1.

I fixed it and now the CI should pass successfully. This issue is also taking care in this pr.

@erwaxler
Copy link
Contributor

Hi @allcloud-sahar-hagbi, thank you for reopening this PR! Thanks for fixing that issue with the snapshot, I'll get this code reviewed by the team and let you know if there is any feedback. Thank you for your contribution!

@erwaxler
Copy link
Contributor

Hi @allcloud-sahar-hagbi , I'm pleased to say this has been merged into the code base and will be available shortly in our next public release. I'll go ahead and close this PR. Thank you again for your support of the Landing Zone Accelerator!

@erwaxler erwaxler closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants