feat: Export admin role and execution role for custom stackset's deployment #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @allcloud-sahar-hagbi, thank you for contributing to the LZA! I'll get this code reviewed by the team and let you know if there is any feedback. Thank you for your contribution! |
|
Hi @allcloud-sahar-hagbi , I'm pleased to say this feature has been merged into the code base and will be included in the next major release, I will go ahead and close this PR. Thank you again for your support of the Landing Zone Accelerator! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a FR for deploying custom stack sets with custom admin role and custom execution role.
The changes is not so much so I'm fell like there is no need to elaborate on them.
Please tell me if something is missing, thx.
EDIT:
The CI has been failed due to un-updated snapshot in release v1.10.0