Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): remove deprecated field #658

Closed
wants to merge 18 commits into from

Conversation

richardkeit
Copy link
Contributor

@richardkeit richardkeit commented Nov 25, 2024

  • Running the installer process, this field is no longer required
| 1732510628170 | $ /landing-zone-accelerator-on-aws/source/packages/@aws-accelerator/tools/node_modules/.bin/ts-node --transpile-only uninstaller.ts --installer-stack-name AWSAccelerator-InstallerStack --ignore-termination-protection true --full-destroy true --partition --debug --delete-data --ignore-termination-protection --delete-bootstraps true --delete-pipelines                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        |
| 1732510628170 | (node:26906) [DEP0128] DeprecationWarning: Invalid 'main' field in '/landing-zone-accelerator-on-aws/source/node_modules/@aws-accelerator/config/package.json' of 'dist/index.js'. Please either fix that or report it to the module author                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            |
  • Silent error (without debug option) is hard to diagnose (given default behaviour in Cloudformation template from the workshop doesn't expose the entry point)
image

@fdjahnke
Copy link
Contributor

Hi @richardkeit thank you for the PR! We merged your changes!
They should be part of our next major release.
I will close this PR for now.

@fdjahnke fdjahnke closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants