chore(deps): bump go to v1.21 #468
Conversation
WalkthroughThis pull request primarily focuses on updating the Go version from 1.20 to 1.21 across the project. This includes changes in GitHub Actions workflows, Dockerfiles, and the Makefile. Additionally, the versions of some dependencies and tools like golangci-lint and starship-action are updated. A minor change is also made in the Changes
TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Files ignored due to filter (2)
- go.mod
- go.sum
Files selected for processing (8)
- .github/workflows/build.yml (1 hunks)
- .github/workflows/lint.yml (3 hunks)
- .github/workflows/test-e2e.yml (1 hunks)
- .github/workflows/test.yml (2 hunks)
- Dockerfile (2 hunks)
- Makefile (1 hunks)
- starship/Dockerfile (2 hunks)
- x/logic/predicate/uri.go (1 hunks)
Files skipped from review due to trivial changes (6)
- .github/workflows/build.yml
- .github/workflows/lint.yml
- .github/workflows/test-e2e.yml
- .github/workflows/test.yml
- Makefile
- x/logic/predicate/uri.go
Additional comments (Suppressed): 4
starship/Dockerfile (2)
1-5: The base image has been updated from
golang:1.20-alpine3.16togolang:1.21-alpine3.17. This change is in line with the PR's goal of upgrading the Go version across the project. Ensure that the new base image is compatible with the existing codebase and dependencies.10-15: The versions of
ca-certificates,build-base,git, andlinux-headershave been updated. This could potentially affect the build process and dependencies. Please verify that these new versions are compatible with the rest of the codebase and that they don't introduce any breaking changes.Dockerfile (2)
1-5: The base image has been updated from
golang:1.20-alpine3.16togolang:1.21-alpine3.17. This change is in line with the Go version upgrade mentioned in the PR summary. Ensure that the new base image is compatible with the existing codebase and dependencies.10-15: The versions of
ca-certificates,git, andlinux-headershave been updated. This could potentially affect the build process and dependencies. Verify that these new versions are compatible with the rest of the system and do not introduce any breaking changes. Also, ensure that the SHA256 checksums for the library files are still valid with the updated dependencies.
amimart
force-pushed
the
chore/bump-go-lang-1.21
branch
from
412f202 to
a82c779
Compare
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Files ignored due to filter (3)
- go.mod
- go.sum
- starship/tests/go.mod
Files selected for processing (9)
- .github/workflows/build.yml (1 hunks)
- .github/workflows/lint.yml (3 hunks)
- .github/workflows/test-e2e.yml (1 hunks)
- .github/workflows/test.yml (2 hunks)
- Dockerfile (2 hunks)
- Makefile (1 hunks)
- README.md (1 hunks)
- starship/Dockerfile (2 hunks)
- x/logic/predicate/uri.go (1 hunks)
Files skipped from review due to trivial changes (7)
- .github/workflows/build.yml
- .github/workflows/lint.yml
- .github/workflows/test-e2e.yml
- .github/workflows/test.yml
- Makefile
- README.md
- x/logic/predicate/uri.go
Additional comments (Suppressed): 4
starship/Dockerfile (2)
1-5: The base image has been updated from
golang:1.20-alpine3.16togolang:1.21-alpine3.17. This is in line with the PR's intent to leverage the features of Go 1.21. Ensure that the new base image is compatible with the rest of the project.10-15: The versions of
ca-certificates,git, andlinux-headershave been updated. Ensure that these new versions are compatible with the rest of the project. Also, verify that the SHA256 checksums for the library files/lib/libwasmvm_muslc.aarch64.aand/lib/libwasmvm_muslc.x86_64.aare still valid with the new base image and package versions.Dockerfile (2)
1-5: The base image has been updated from
golang:1.20-alpine3.16togolang:1.21-alpine3.17. This is in line with the PR's intent to update the Go version across the project. Ensure that the new base image is compatible with the rest of the project and that all dependencies are still met.10-15: The versions of
ca-certificates,git, andlinux-headershave been updated. Ensure that these new versions are compatible with the rest of the project and that they don't introduce any breaking changes. Also, verify that the SHA256 checksums for thelibwasmvm_muslc.aarch64.aandlibwasmvm_muslc.x86_64.afiles remain the same, as they have not been updated in this PR.
|
Sure! It's great 😃 |
amimart
force-pushed
the
chore/bump-go-lang-1.21
branch
from
4390bcb to
76905db
Compare
Would you like to leverage the advantages offered by Go version 1.21, such as the slices package, to make it easier to implement PR #462.
Also bumped the version of golangci/golangci-lint to
v1.54.Summary by CodeRabbit
uri.gofile, indicating an improvement in code quality.starship-actiondependency in the end-to-end testing workflow, potentially improving the reliability of our tests.