-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 Adopt gitmoji (+ some others upptime emojis) #8
Conversation
WalkthroughThe changes primarily focus on refining the linting process in the GitHub workflow and commitlint configuration. The workflow now includes all actors, except Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- .github/workflows/lint.yml (1 hunks)
- commitlint.config.js (1 hunks)
Files skipped from review due to trivial changes (1)
- commitlint.config.js
Additional comments: 1
.github/workflows/lint.yml (1)
- 12-18: The
lint-commits
job now runs for all actors exceptdependabot[bot]
. Ensure that this change doesn't introduce any unwanted behavior, especially ifupptime-bot
was previously excluded for a specific reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love that 😉
Transition to gitmoji-style for commit messages as this is the default practice for upptime. Accordingly, the linter configuration has be configured to accommodate the use of emojis.
Summary by CodeRabbit
Chores:
lint-commits
job will now run for all contributors, including 'upptime-bot', enhancing the consistency of code quality checks across all commits.commitlint.config.js
. This includes rules for subject case, type enumeration, and header maximum length, improving the clarity and consistency of commit messages. The type enumeration now supports a variety of emoji and Unicode characters, allowing for more expressive commit messages.