Add default behaviour override for flag selectors. #3252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exitare
changed the title
|
@Helias anything missing here ? |
libs/shared/selectors/src/selectors/flags-selector/flags.service.ts
Outdated
Show resolved
Hide resolved
libs/shared/selectors/src/selectors/flags-selector/flags.service.ts
Outdated
Show resolved
Hide resolved
FrancescoBorzi
approved these changes
Jan 18, 2025
|
Just a couple of minor suggestions and approved already! |
Helias
approved these changes
Jan 19, 2025
|
Thank you a lot! |
Helias
added a commit
that referenced
this pull request
Jan 19, 2025
* Add quest_template_locale table * Add locale selection, add tests * ci: fix I18n sync ignoring master branch (#3225) * fix(i18n): key for conditions (#3226) * chore(creature_template): update initial unit class from being 0 to 1 (warrior class) (#3235) * chore(creature_template_model): change initial probability from 0 to 1 (#3234) Co-authored-by: Stefano Borzì <[email protected]> * chore(deps): update dependency @types/node to v22.10.5 (#3229) * chore(deps): update dependency @types/node to v22.10.5 * Fix missing translation keys --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: i18n Sync Bot <[email protected]> Co-authored-by: Francesco Borzì <[email protected]> * feat(pagination): update editor to jump back to first page after a new search was triggered (#3233) * Update editor to jump back to first page after a new search was triggered * Remove debug line of code * chore(deps): update dependency @swc/core to v1.10.7 (#3220) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update nx monorepo to v20.3.1 (#3238) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency wait-on to v8.0.2 (#3240) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency lint-staged to v15.3.0 (#3221) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fixes Fix QuestTemplateLocale tests Fix <ngx-datatable-column> to self-closing tags Add test case to verify string-typed field assignment * fix(npc-vendor): wrong color for item extended cost. (#3249) * chore(deps): update dependency electron to v33.3.1 (#3241) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Improve item quality visibility (#3250) * Update handler to allow for a custom class. * Add more tests to fix coverage * Fix code coverage * Update select.service.spec.ts * Fix tests * chore(deps): update dependency @types/node to v22.10.6 (#3251) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: add default behaviour override for flag selectors. (#3252) * Update default behaviour override for flag selectors * Address code review * feat(game-tele): add new editor game-tele (#3227) * Start adding game_tele * Add working game_tele * Fix errors * Fix typo * Update game-tele.integration.spec.ts * Fix typo * Fix unit test * Update based on code review * Fix linting * Update code * Add missing map selector * Update sidebar & add missing translation * Address code review * chore(deps): update dependency electron to v34 (#3254) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/node to v22.10.7 (#3257) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: improve code quality --------- Co-authored-by: Exitare <[email protected]> Co-authored-by: Stefano Borzì <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: i18n Sync Bot <[email protected]> Co-authored-by: Francesco Borzì <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3239
It's possible to override the default behavior for the flag selector now. If the behavior is overridden, it defaults to -1 when all bits are unset. Otherwise everything stays the same.