Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug only finds a single auction #129 from azerothcore\mod-ah-bot #132

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

Jaytapp
Copy link

@Jaytapp Jaytapp commented Jan 16, 2025

#129

remove break in AuctionHouseBot::getNofAuctions to avoid always returning 1 auction when using ConsiderOnlyBotAuctions true

Changes Proposed:

remove the "break" in AuctionHouseBot::getNofAuctions()

Issues Addressed:

SOURCE:

Tests Performed:

  • tested windows and linux
  • build correctly on all platform

How to Test the Changes:

  1. use ConsiderOnlyBotAuctions true in config
  2. Check that AuctionHouseBot::getNofAuctions returns the correct number of action from the AH

…\mod-ah-bot

azerothcore#129

remove break in AuctionHouseBot::getNofAuctions to avoid always returning 1 auction when using ConsiderOnlyBotAuctions true
@Helias Helias changed the title Fix Bug: Only finds a single auction #129 from azerothcore\mod-ah-bot fix: bug only finds a single auction #129 from azerothcore\mod-ah-bot Jan 16, 2025
@Helias Helias merged commit ce277a4 into azerothcore:master Jan 16, 2025
1 check passed
@Helias
Copy link
Member

Helias commented Jan 16, 2025

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants