Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conf #21

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Fix conf #21

merged 1 commit into from
Dec 4, 2024

Conversation

Blacktooth04
Copy link
Contributor

Changes Proposed:

  • Change comment to show 0 = false and 1 = true
  • Change comment to show that StarterGuild.Enable default = 1

Issues Addressed:

  • N/A

SOURCE:

Tests Performed:

  • Builds without errors on Windows 11
  • Created new character, logged in with that character, verified they were a part of guild

How to Test the Changes:

  1. Clean/Build
  2. Run SQL script if necessary
  3. Start auth and world servers
  4. Start client
  5. Log into account
  6. Create new character
  7. Log in with new character
  8. Verify they are a part of starter guild

@sudlud
Copy link
Member

sudlud commented Dec 4, 2024

Thanks for the PR, do you also want to fix the default value for announce in the cpp file

https://github.com/azerothcore/mod-starter-guild/blob/master/src/mod_starterguild.cpp#L7

Currently set to true, but config default is false

@Blacktooth04
Copy link
Contributor Author

Blacktooth04 commented Dec 4, 2024

@sudlud My C++ isn't very good, but that if statement should be checking the config value for StarterGuild.Announce. If set to false (default), the if statement would not be run.

I don't think I need to update the .cpp file

@sudlud
Copy link
Member

sudlud commented Dec 4, 2024

Yes it loads the config value and the last value on that line is the "default" value it uses if this option is missing from the config file.

Right now to me it looks like it is different from the default setting in the config file

@sudlud sudlud merged commit ec8c097 into azerothcore:master Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants