Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow schedule operator to manage any resource #15

Closed
wants to merge 1 commit into from

Conversation

mkjpryor
Copy link
Collaborator

No description provided.

@mkjpryor mkjpryor requested a review from JohnGarbutt April 24, 2024 11:04
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

resources: ["clusterrolebindings"]
verbs: ["get", "list", "create", "update", "patch"]
# The operator has fetch and delete permissions for every resource
- apiGroups: ["*"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would much rather this was more specific. It feels like an honey pot letting it access everything.

Maybe we need to add these permissions higher up our tree of operators somewhere?

For now, could we just add the extra bits we need.

- apiGroups: ["*"]
resources: ["*"]
verbs:
- get
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, the big list was a cut and paste error I think.

Copy link
Collaborator

@JohnGarbutt JohnGarbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the permissions are too board here, we need a better compromise

@mkjpryor mkjpryor closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants