Add scheduled delete #3
Conversation
There was a problem hiding this comment.
Not sure how I feel about this approach.
A lot of me favours a polling approach using kopf timers where we check to see if the current time is after the notAfter time and delete if it is.
The implementation would be a lot simpler, but obviously the delete might not happen until the polling interval after notAfter. However, the execution time of async tasks is also not completely deterministic either, since it is relying on cooperative concurrency.
Because we are using asyncio, I don't have any concerns over scaling with the timers approach. In fact I have more concerns over tracking a large number of tasks.
|
Yeah, I got confused with the timers really, couldn't decide on a polling interval, probably simpler than tracking tasks though. Thoughts? I guess the memo can hold the time, so we just check that in the timer? |
And add extra test for skipping the delete.
|
OK, ready for review again. That last comment opened a whole can of (quite useful!) worms. |
No description provided.