Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed simapp imports #59

Merged
merged 2 commits into from
Jul 10, 2024
Merged

refactor: removed simapp imports #59

merged 2 commits into from
Jul 10, 2024

Conversation

poorphd
Copy link

@poorphd poorphd commented Jul 2, 2024

Description

Currently, Canto does not use VoteExtension, so the corresponding baseapp option that uses the VoteExtensionHandler from simapp has been removed.
Moreover, the current VoteExtensionHandler from simapp is a dummy handler and should not be used in production.
https://github.com/cosmos/cosmos-sdk/blob/v0.50.7/simapp/abci.go#L15-L28

Closes: L-9


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@poorphd poorphd requested a review from dudong2 July 2, 2024 08:14
@poorphd poorphd self-assigned this Jul 2, 2024
Currently, Canto does not use VoteExtension, so the corresponding baseapp option that uses the VoteExtensionHandler from simapp has been removed.
@poorphd poorphd force-pushed the patch/issue-L-9 branch from 76bfe79 to ee925dc Compare July 2, 2024 08:32
@dudong2
Copy link

dudong2 commented Jul 2, 2024

Is it ok to run a node without registering a vote extension handler?

@poorphd
Copy link
Author

poorphd commented Jul 2, 2024

Yes, it's ok.
baseapp's ExtendVote and VerifyVoteExtension just return an error if handlers are not set (= vote extensions are not enabled).
https://github.com/cosmos/cosmos-sdk/blob/v0.50.7/baseapp/abci.go#L567-L572
https://github.com/cosmos/cosmos-sdk/blob/v0.50.7/baseapp/abci.go#L622-L627

@poorphd poorphd marked this pull request as ready for review July 9, 2024 07:32
@poorphd poorphd requested review from dongsam and zsystm July 9, 2024 07:32
Copy link

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

note for vote extension option: when we run node without vote extension handler, we should make sure that vote extension is disabeld in cometBFT configuration.

@poorphd poorphd merged commit 6e90965 into v8/develop Jul 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QA Report
4 participants