Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove RandomizedParams from AppModuleSimulation interface #61

Closed
wants to merge 1 commit into from

Conversation

poorphd
Copy link

@poorphd poorphd commented Jul 3, 2024

Description

RandomizedParams has been removed from the AppModuleSimulation interface. Previously, it generated random parameter changes during simulations through ParamChangeProposal, which is now legacy. Since all modules have been migrated away from using ParamChangeProposal, we can now safely remove RandomizedParams from the interface.

Adding simulation (including MsgUpdateParams proposal) will be added in a separated PR,

Closes: L-2, L-7


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@poorphd poorphd requested a review from dudong2 July 3, 2024 07:03
@poorphd poorphd self-assigned this Jul 3, 2024
@poorphd
Copy link
Author

poorphd commented Jul 9, 2024

simulation for other canto modules are in a separated PR #65

dudong2
dudong2 approved these changes Jul 9, 2024
@dudong2 dudong2 self-requested a review July 9, 2024 09:40
@dudong2
Copy link

dudong2 commented Jul 9, 2024

IMO it looks good to merge this PR with pr-65, as modifications to the x/coinswap are also being made on pr-65, which causes confusion.

@poorphd poorphd closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QA Report
2 participants