Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump up iavl v1.1.4 #77

Merged
merged 1 commit into from
Jul 24, 2024
Merged

feat: bump up iavl v1.1.4 #77

merged 1 commit into from
Jul 24, 2024

Conversation

dudong2
Copy link

@dudong2 dudong2 commented Jul 24, 2024

Description

issue

super vali(more than 67% power) is operating by reading genesis.json. When a full node tries to sync with the super vali and then restarts, occur app hash collision.

how to test

  1. set node setting initial height with N(N > 1)
  2. start the node and check app hash for modules
  3. terminate and restart node
  4. check app hash for modules
  5. compare the app hash for modules that have remained unchanged(like crisis, ...), ensuring that the values are equal

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dudong2 dudong2 self-assigned this Jul 24, 2024
@dudong2 dudong2 requested review from dongsam, zsystm and poorphd July 24, 2024 06:01
Copy link

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 merged commit d4c9382 into v8/develop Jul 24, 2024
8 checks passed
@dudong2 dudong2 deleted the patch/apphash branch July 24, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants