Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply cronos x/tx #210

Merged

Conversation

dudong2
Copy link

@dudong2 dudong2 commented Oct 30, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dudong2 dudong2 self-assigned this Oct 30, 2024
Copy link

@dudong2 your pull request is missing a changelog!

mmsqe and others added 2 commits October 30, 2024 18:57
…osmos#808)

* fix(x/tx): don't shadow Amino marshalling error messages (cosmos#19955)

* use directly instead of cast

---------

Co-authored-by: Antonio Pitasi <[email protected]>
@dudong2 dudong2 requested review from dongsam and cloudgray November 6, 2024 04:48
Copy link
Collaborator

@cloudgray cloudgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 merged commit 3f9b5f9 into basechain/develop-v0.50.8-x/tx/v0.13.5 Nov 6, 2024
42 of 44 checks passed
@dudong2 dudong2 deleted the feat/apply-cronos-x/tx branch November 6, 2024 07:25
dudong2 added a commit that referenced this pull request Dec 17, 2024
* feat(x/tx): support bytes field as signer (cosmos#21850)

* Problem: multisig account failed on threshold encode after send tx   (cosmos#808)

* fix(x/tx): don't shadow Amino marshalling error messages (cosmos#19955)

* use directly instead of cast

---------

Co-authored-by: Antonio Pitasi <[email protected]>

* feat: Fix datarace

---------

Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Antonio Pitasi <[email protected]>
dudong2 added a commit that referenced this pull request Dec 17, 2024
* feat(x/tx): support bytes field as signer (cosmos#21850)

* Problem: multisig account failed on threshold encode after send tx   (cosmos#808)

* fix(x/tx): don't shadow Amino marshalling error messages (cosmos#19955)

* use directly instead of cast

---------

Co-authored-by: Antonio Pitasi <[email protected]>

* feat: Fix datarace

---------

Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Antonio Pitasi <[email protected]>
@dudong2 dudong2 mentioned this pull request Dec 17, 2024
20 tasks
dudong2 added a commit that referenced this pull request Dec 19, 2024
* feat(x/tx): support bytes field as signer (cosmos#21850)

* Problem: multisig account failed on threshold encode after send tx   (cosmos#808)

* fix(x/tx): don't shadow Amino marshalling error messages (cosmos#19955)

* use directly instead of cast

---------



* feat: Fix datarace

---------

Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Antonio Pitasi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants