Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Sync with original cosmos-sdk #477

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

dudong2
Copy link

@dudong2 dudong2 commented Jan 15, 2025

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dudong2 dudong2 self-assigned this Jan 15, 2025
Copy link

@dudong2 your pull request is missing a changelog!

baseapp/baseapp.go Outdated Show resolved Hide resolved
@dudong2 dudong2 changed the title fix: Parallel checktx ante-handler error Refactor: Sync with original cosmos-sdk Jan 15, 2025
@dudong2 dudong2 force-pushed the fix/ante-handler-error branch from 7191568 to 49a6b7c Compare January 15, 2025 08:41
Copy link

@jasonsong0 jasonsong0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 merged commit 9553b7c into basechain/develop-v0.50.11 Jan 15, 2025
36 of 45 checks passed
@dudong2 dudong2 deleted the fix/ante-handler-error branch January 15, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants