Refer to get_class results as strings

get_class returns a string not a type.

Using the bare class name is now a fatal error in PHP 8.

board.php

@@ -57,7 +57,7 @@ public function applyWithoutChecks(Move $move, $updateLocations = false) {
         }
       }
     }
-    return $board;
+    return $this->board;
   }
 
   private function addLocation(Point $pointToAdd) {
@@ -104,7 +104,7 @@ public function score(Move $move) {
     $board = clone $this;
     $board->applyWithoutChecks($move);
     $lines = $move->lines($board);
-    $points = 0;
+    $score = 0;
     foreach ($lines as $line) {
       if ($line->length() === count(Color::colors())) {
         $score += Score::QWIRKLE_BONUS;
@@ -147,6 +147,7 @@ public function __toString() {
     $leftmost -= 1;
     $rightmost += 2;
 
+    $s = '';
     for ($y = $highest; $y < $lowest; $y++) {
       $a = [];
       for ($x = $leftmost; $x < $rightmost; $x++) {

event.php

@@ -2,7 +2,7 @@
 
 class Event {
   public function draw(Player $player, array $tiles) {
-    Assert::type($tiles, Tile);
+    Assert::type($tiles, 'Tile');
     $hand = new Hand($tiles); 
     $this->p("{$player} draws {$hand}");
     if (count($tiles) < $player->hand()->size()) {

game.php

@@ -7,7 +7,7 @@ class Game {
   private $scores;
 
   public function __construct(array $players, $tiles = null) {
-    Assert::type($players, Player);
+    Assert::type($players, 'Player');
     $this->players = $players;
     $this->random = $tiles === null;
     $this->tiles = $tiles;
@@ -67,7 +67,7 @@ public function go() {
         }
       }
     }
-    $event->gameEnd($scores);
+    $event->gameEnd($this->scores);
   }
 
   public function scores() {

hand.php

@@ -4,7 +4,7 @@ class Hand {
   use Tiles;
 
   public function __construct(array $tiles = []) {
-    Assert::type($tiles, Tile);
+    Assert::type($tiles, 'Tile');
     $this->tiles = $tiles;
   }
 

line.php

@@ -4,7 +4,7 @@ class Line {
   use Tiles;
 
   public function __construct(array $placements = []) {
-    Assert::type($placements, Placement);
+    Assert::type($placements, 'Placement');
     $this->placements = $placements;
   }
 

move.php

@@ -4,7 +4,7 @@ class Move {
   const STARTING_INDEX = 99;
 
   public function __construct($placements) {
-    Assert::type($placements, Placement);
+    Assert::type($placements, 'Placement');
     $this->placements = $placements;
   }
 

player.php

@@ -32,7 +32,7 @@ public function discard() {
   }
 
   public function startingMove(array $tiles) {
-    Assert::type($tiles, Tile);
+    Assert::type($tiles, 'Tile');
     $lines = [];
     foreach ($tiles as $tile) {
       if (!isset($lines[$tile->color()->name()])) {

players/cautiousplayer.php

@@ -49,14 +49,14 @@ private function missingPieces($line) {
       throw new IllegalArgumentException("This line does not have a shared property ($line).");
     }
     $missing = [];
-    if (get_class($sharedProperty) === Shape) {
+    if (get_class($sharedProperty) === 'Shape') {
       foreach (Color::colors() as $color) {
         $tile = Tile::get($color, $sharedProperty);
         if (!$line->contains($tile)) {
           $missing[] = $tile;
         }
       }
-    } elseif (get_class($sharedProperty) === Color) {
+    } elseif (get_class($sharedProperty) === 'Color') {
       foreach (Shape::shapes() as $shape) {
         $tile = Tile::get($sharedProperty, $shape);
         if (!$line->contains($tile)) {

scores.php

@@ -4,7 +4,7 @@ class Scores {
   private $scores = [];
 
   public function __construct(array $players) {
-    Assert::type($players, Player);
+    Assert::type($players, 'Player');
     foreach ($players as $player) {
       $this->scores[] = new Score($player, 0);
     }

tiles.php

@@ -14,6 +14,7 @@ public function sharedProperty() {
 
   public function sharedProperties() {
     $sharedProperty = null;
+    $sharedProperties = [];
     foreach (Color::colors() as $color) {
       foreach ($this->tiles() as $tile) {
         if ($sharedProperty === null || $sharedProperty === $tile->color()) {