Remove skhema as dependency #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipex
commented
Dec 16, 2024
lib/json-schema.ts
Outdated
|
|
||
| const JSON_SCHEMA_SCHEMA = { | ||
| $schema: 'http://json-schema.org/draft-07/schema#', | ||
| $id: 'jellyfish-meta-schema', |
There was a problem hiding this comment.
I think this schema can be simplified, but I'm not familiar with json-schema or AJV to identify what is superfluous
pipex
force-pushed
the
json-schema-is-valid
branch
2 times, most recently
from
ff7bf78 to
317eebc
Compare
pipex
force-pushed
the
json-schema-is-valid
branch
3 times, most recently
from
4a8e565 to
f31c103
Compare
pipex
force-pushed
the
json-schema-is-valid
branch
from
f31c103 to
188ad5f
Compare
This moves the `isValid` method from the [skhema module](https://github.com/balena-io-modules/skhema) into an internal json-schema module since skhema is not being maintained or used anywhere else. Change-type: minor Depends-on: #74
pipex
force-pushed
the
json-schema-is-valid
branch
from
188ad5f to
dffa41e
Compare
myarmolinsky
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the isValid method from the skhema module into an internal json-schema module since skhema is not being maintained or used anywhere else.
Change-type: minor
Depends-on: #74