Add beagleplay support take 4 build branch #686

delhiryder · 2024-07-18T15:03:29Z

Re-opened the PR branch (after a successful force push)

resin-jenkins · 2024-07-18T15:05:07Z

Can one of the admins verify this patch?

acostach · 2024-07-19T08:24:14Z

acostach · 2024-07-19T09:07:16Z

layers/meta-balena-beaglebone/recipes-core/images/balena-image.bbappend

@@ -6,3 +6,6 @@ IMAGE_ROOTFS_SIZE:beaglebone-ai64 = "733184"
 IMAGE_INSTALL:append:beaglebone = " bb-org-overlays fix-mmc-bbb bb-wl18xx-bluetooth bb-wl18xx-wlan0"
 IMAGE_INSTALL:append:beaglebone-ai64 = " mmc-utils vxd-dec-fw"
 IMAGE_INSTALL:append:beaglebone-pocket = " boot-scripts"
+IMAGE_INSTALL:append:beagleplay = " mmc-utils"
+
+IMAGE_ROOTFS_SIZE:beagleplay = "1966080"


Root partitions are way too large, 733184 would be more appropriate

@delhiryder

Hi Alexandru, please refer to this thread from zulip. @floion and I have already gone down the path of trying to reduce the size of the root partition, but not had any success. Here's the original post from Alex (from last September).

Hi @delhiryder , the links you shared take me to the extlinux discussions, I don't see anything about the boot and root partitions sizes. The problem with this is that the flasher image cannot be archived using zip due to the 4GB limit for zip files. cc @floion

acostach · 2024-07-19T09:07:39Z

layers/meta-balena-beaglebone/recipes-core/images/balena-image.inc

@@ -2,6 +2,8 @@ IMAGE_FSTYPES:append:beaglebone = " balenaos-img balenaos-img.bmap"
 IMAGE_FSTYPES:append:beaglebone-pocket = " balenaos-img"
 IMAGE_FSTYPES:append:beagleboard-xm = " balenaos-img"

+BALENA_BOOT_SIZE:beagleplay = "327680"


Again, ~100MB should be more than sufficient for the boot partition

See the comment above.

acostach · 2024-07-19T09:09:09Z

layers/meta-balena-beaglebone/recipes-core/systemd/systemd_%.bbappend

@@ -0,0 +1,18 @@
+FILESEXTRAPATHS:append := ":${THISDIR}/${PN}"


We should leave a note here too on the reason for disabling the watchdog

I have already added a line to the commit message: fc7769e (reproduced below):

"Also, disabled the hardware watchdog (due an ongoing open issue, whose fix is currently being tested). Add the "test_watchdog" package to the kernel package (for easy verification of the patch, when it become available)."

It doesn't hurt to leave a comment in the file because it's quicker for someone investigating a problem and looking at this file on a remote device to understand the reason behind the configuration. Otherwise he would have to go find the device integration repository, search for the yocto package as well as for the layer which provides/modifies it then look in the git history for it, to finally understand why. cc @floion

layers/meta-balena-beaglebone/recipes-bsp/u-boot/u-boot-bb.org_%.bbappend

floion · 2024-07-22T08:19:46Z

@resin-jenkins test this please

acostach · 2024-07-23T15:08:10Z

@resin-jenkins retest this please

acostach · 2024-07-31T11:47:51Z

@resin-jenkins retest this please

rcooke-warwick · 2024-08-01T11:32:53Z

@resin-jenkins retest this please

Added a new 'beagleplay' device type coffee script. Also updated the "#Supported Machines" sections of the local.conf.sample to make the 'beagleplay' machine target available for building via bitbake. Signed-off-by: Sidd Gupta <[email protected]>

For the beagleplay MC targets, change this to "u-boot-bb.org" (this is maintained by the bb/ti team). Explicity set the UBOOT_GIT_URI to the one from git.beagleboard.org. Also specified the release version and SRCREV. Added an extlinux.conf file, to ensure that the OS boots up properly. Added patches suggested by the beagleboard discord community - these were needed to get the wlcore startup errors being encountered during initial bootup. Signed-off-by: Sidd Gupta <[email protected]>

Add kernel wlan_en regulator patch as suggested by Nishanth Menon (of TI). Also, disabled the hardware watchdog (due an ongoing open issue, whose fix is currently being tested). Add the "test_watchdog" package to the kernel package (for easiy verification of the patch, when it become available). Signed-off-by: Sidd Gupta <[email protected]>

Added appropriate variables and append/remove packages and packagegroups to the balena-image* recipes. Had to increase the IMAGE_ROOTFS_SIZE to 1966080 to enable the recipe to run to completion. Signed-off-by: Sidd Gupta <[email protected]>

Updated the balena-image-flasher and associated dependent recipes to support building a balena-image-flasher image for the beagleplay device. Changelog-entry: Add beagleplay support Signed-off-by: Sidd Gupta <[email protected]>

Make sure to get the wl18xx-conf.bin file from the `beagleboard` repo (instead of the git.ti.com one). This is needed (in conjunction with the 6.1.80 kernel) to make sure the wifi interface comes up properly. Signed-off-by: Sidd Gupta <[email protected]>

Updated the balena-image-flasher and associated dependent recipes to support bootup using an extlinux.conf file. This had been removed accidentally. Changelog-entry: Add beagleplay support Signed-off-by: Sidd Gupta <[email protected]>

acostach · 2024-08-20T08:58:20Z

@resin-jenkins retest this please

This is needed for u-boot to be loaded from sd-card, and also alows us to drop the extlinux.conf and kernel image from the boot partition, and use the embedded u-boot scripts to load the kernel and dtb from the rootfs instead. Signed-off-by: Alexandru Costache <[email protected]>

We drop using the extlinux completely, and switch to using boot scripts to load the kernel and dtb from the appropriate boot medium root filesystem. We also add the mandatory CRC32 checks. Signed-off-by: Alexandru Costache <[email protected]>

acostach · 2024-08-22T15:37:56Z

Relies on balena-os/meta-balena#3494 being merged for booting the flasher image from the sd-card. Since the autokit cannot control the USR and RST buttons, having u-boot already present on the eMMC is sufficient for the autokit

acostach · 2024-08-22T15:42:02Z

layers/meta-balena-beaglebone/recipes-kernel/linux-firmware/linux-firmware_%.bbappend

@delhiryder do you know why this recipe was needed? It seems the device works with the linux-firmware provided by meta-balena. Unless there is a specific reason for it, we can drop this and thus decrease partitions and the total image size

Hi @delhiryder please delete this recipe as it was tested by Alex that it does not seem to be needed.

acostach · 2024-08-23T03:17:34Z

@resin-jenkins test this please

acostach · 2024-08-25T20:43:39Z

@resin-jenkins test this please

acostach · 2024-08-28T13:52:25Z

@resin-jenkins test this please

floion · 2024-08-30T07:32:45Z

layers/meta-balena-beaglebone/recipes-core/images/balena-image-flasher.bbappend

@@ -2,6 +2,10 @@ include balena-image.inc

 BALENA_BOOT_PARTITION_FILES:append:beaglebone = " uEnv.txt_internal:"

+BALENA_BOOT_PARTITION_FILES:append:beagleplay = " \


Hi @delhiryder this commit can be removed completely since @acostach worked out in 1eae4da that we can skip using extlinux.conf

floion · 2024-08-30T07:39:41Z

...es-kernel/linux/linux-bb.org/0001-Changed-the-behavior-of-the-wlan_en-regulator-3-to-r.patch

@@ -0,0 +1,24 @@
+From 1920d52d6f37b57d43f9adf533fd40045fe3132b Mon Sep 17 00:00:00 2001


This patch is not being applied and also tested that without it the wifi does not have issues so it can be deleted from here @delhiryder

The old partition sizes were generating an 8GB image, which is more than what can be compressed in a zip. Dropping the custom linux-firmware recipe as well as the kernel from the boot partition allows us to use the standard balenaOS recipe and to also use the same partitions sizes as the beagle-ai64 Signed-off-by: Alexandru Costache <[email protected]>

The device boots, has functional usb, hdmi, ethernet ports as well as the wifi is working without this custom recipe. Unless it is necessary for a particular reason, it can be dropped. Signed-off-by: Alexandru Costache <[email protected]>

Signed-off-by: Alexandru Costache <[email protected]>

Changelog-entry: layers/meta-balena: Update to v6.0.24 Signed-off-by: Alexandru Costache <[email protected]>

acostach · 2024-09-17T07:16:18Z

@resin-jenkins test this please

acostach enabled auto-merge July 18, 2024 15:06

acostach requested a review from floion July 18, 2024 15:06

acostach reviewed Jul 19, 2024

View reviewed changes

layers/meta-balena-beaglebone/recipes-bsp/u-boot/u-boot-bb.org_%.bbappend Show resolved Hide resolved

delhiryder added 7 commits August 20, 2024 06:23

balena-image-flasher: Added beagleplay support.

19f2d62

Updated the balena-image-flasher and associated dependent recipes to support building a balena-image-flasher image for the beagleplay device. Changelog-entry: Add beagleplay support Signed-off-by: Sidd Gupta <[email protected]>

balena-image-flasher: Add back extlinux.conf

3fdf35e

Updated the balena-image-flasher and associated dependent recipes to support bootup using an extlinux.conf file. This had been removed accidentally. Changelog-entry: Add beagleplay support Signed-off-by: Sidd Gupta <[email protected]>

acostach force-pushed the add_beagleplay_support_take_4_build_branch branch from ad66aed to 3fdf35e Compare August 20, 2024 06:23

acostach added 2 commits August 21, 2024 16:42

u-boot-bb.org: Rework balenaOS integration

1eae4da

We drop using the extlinux completely, and switch to using boot scripts to load the kernel and dtb from the appropriate boot medium root filesystem. We also add the mandatory CRC32 checks. Signed-off-by: Alexandru Costache <[email protected]>

acostach reviewed Aug 22, 2024

View reviewed changes

floion force-pushed the add_beagleplay_support_take_4_build_branch branch 2 times, most recently from 9f2c59c to 78a5976 Compare August 29, 2024 10:11

floion force-pushed the add_beagleplay_support_take_4_build_branch branch from 78a5976 to 2a088d1 Compare August 29, 2024 10:27

floion mentioned this pull request Aug 30, 2024

Add beagleplay support take 4 #679

Closed

floion reviewed Aug 30, 2024

View reviewed changes

floion force-pushed the add_beagleplay_support_take_4_build_branch branch from 2a088d1 to 008935d Compare August 30, 2024 07:47

acostach added 3 commits September 16, 2024 15:00

linux-firmware: Drop custom recipe

145dbb6

The device boots, has functional usb, hdmi, ethernet ports as well as the wifi is working without this custom recipe. Unless it is necessary for a particular reason, it can be dropped. Signed-off-by: Alexandru Costache <[email protected]>

u-boot-org: Ensure u-boot isn't deployed from sstate

84cd7dc

Signed-off-by: Alexandru Costache <[email protected]>

acostach force-pushed the add_beagleplay_support_take_4_build_branch branch from 008935d to 231984b Compare September 16, 2024 15:01

layers/meta-balena: Update to v6.0.24

6166bf2

Changelog-entry: layers/meta-balena: Update to v6.0.24 Signed-off-by: Alexandru Costache <[email protected]>

acostach force-pushed the add_beagleplay_support_take_4_build_branch branch from 231984b to 6166bf2 Compare September 16, 2024 15:28

rcooke-warwick requested review from acostach and floion September 18, 2024 11:41

rcooke-warwick mentioned this pull request Sep 19, 2024

patch: Add GHA Built Test Deploy workflows #692

Merged

7 tasks

floion approved these changes Sep 19, 2024

View reviewed changes

acostach merged commit b826c36 into master Sep 19, 2024
51 checks passed

acostach deleted the add_beagleplay_support_take_4_build_branch branch September 19, 2024 10:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add beagleplay support take 4 build branch #686

Add beagleplay support take 4 build branch #686

delhiryder commented Jul 18, 2024

resin-jenkins commented Jul 18, 2024

acostach commented Jul 19, 2024

acostach Jul 19, 2024

acostach Jul 22, 2024

delhiryder Jul 25, 2024

acostach Jul 31, 2024

acostach Jul 19, 2024

delhiryder Jul 25, 2024

acostach Jul 19, 2024 •

edited

Loading

delhiryder Jul 25, 2024

acostach Jul 31, 2024

floion commented Jul 22, 2024

acostach commented Jul 23, 2024

acostach commented Jul 31, 2024

rcooke-warwick commented Aug 1, 2024

acostach commented Aug 20, 2024

acostach commented Aug 22, 2024

acostach Aug 22, 2024 •

edited

Loading

floion Aug 30, 2024

delhiryder Sep 9, 2024

acostach commented Aug 23, 2024

acostach commented Aug 25, 2024

acostach commented Aug 28, 2024

floion Aug 30, 2024

delhiryder Sep 9, 2024

floion Aug 30, 2024

delhiryder Sep 9, 2024

acostach commented Sep 17, 2024

		@@ -0,0 +1,18 @@
		FILESEXTRAPATHS:append := ":${THISDIR}/${PN}"

		@@ -2,6 +2,10 @@ include balena-image.inc

		BALENA_BOOT_PARTITION_FILES:append:beaglebone = " uEnv.txt_internal:"

		BALENA_BOOT_PARTITION_FILES:append:beagleplay = " \

		@@ -0,0 +1,24 @@
		From 1920d52d6f37b57d43f9adf533fd40045fe3132b Mon Sep 17 00:00:00 2001

Add beagleplay support take 4 build branch #686

Add beagleplay support take 4 build branch #686

Conversation

delhiryder commented Jul 18, 2024

resin-jenkins commented Jul 18, 2024

acostach commented Jul 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acostach Jul 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

floion commented Jul 22, 2024

acostach commented Jul 23, 2024

acostach commented Jul 31, 2024

rcooke-warwick commented Aug 1, 2024

acostach commented Aug 20, 2024

acostach commented Aug 22, 2024

acostach Aug 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acostach commented Aug 23, 2024

acostach commented Aug 25, 2024

acostach commented Aug 28, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acostach commented Sep 17, 2024

acostach Jul 19, 2024 •

edited

Loading

acostach Aug 22, 2024 •

edited

Loading