Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RISC-V AIA IMSIC #117

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Conversation

D3boker1
Copy link
Collaborator

@D3boker1 D3boker1 commented Dec 16, 2023

RISC-V AIA APLIC support:

  • Change the Bao's interrupt reservation mechanism;
  • Add MSI Mode support in (V)APLIC driver;
  • IMSIC driver.
  • VIMSIC driver

Software Versions:

QEMU - v7.1.0
Linux - https://github.com/avpatel/linux/tree/riscv_aia_v1
OpenSBI - 1.2

@josecm
Copy link
Member

josecm commented Dec 16, 2023

@D3boker1 before starting the review I'd ask you to:

  1. Resolve the conflicts with the main branch;
  2. Make the history a little more granular, so we can better understand the structure of the introduced changes.

@josecm
Copy link
Member

josecm commented Aug 19, 2024

@ninolomata @DavidMCerdeira I believie this is ready to be merged. Please add your reviews.

@D3boker1 it would be great if you could also add your approval after my changes.

josecm
josecm previously approved these changes Aug 19, 2024
@D3boker1
Copy link
Collaborator Author

Hi @josecm!

I have tested these changes on AlSaqr SoC (dual-core version), and everything went smoothly.
It looks great to me!

DavidMCerdeira
DavidMCerdeira previously approved these changes Aug 21, 2024
src/arch/riscv/interrupts.c Show resolved Hide resolved
src/arch/riscv/interrupts.c Outdated Show resolved Hide resolved
src/arch/riscv/irqc/aia/imsic.c Outdated Show resolved Hide resolved
src/arch/riscv/irqc/aia/imsic.c Outdated Show resolved Hide resolved
src/arch/riscv/irqc/aia/inc/aplic.h Outdated Show resolved Hide resolved
src/arch/riscv/irqc/aia/inc/irqc.h Outdated Show resolved Hide resolved
src/arch/riscv/irqc/aia/inc/irqc.h Outdated Show resolved Hide resolved
src/arch/riscv/irqc/aia/vaplic.c Outdated Show resolved Hide resolved
src/arch/riscv/irqc/aia/inc/imsic.h Outdated Show resolved Hide resolved
src/arch/riscv/irqc/aia/inc/imsic.h Outdated Show resolved Hide resolved
@DavidMCerdeira
Copy link
Member

@D3boker1 Please rebase this with main

@josecm
Copy link
Member

josecm commented Sep 28, 2024

@DavidMCerdeira I've rebased this on main. I think the PR is ready to go.

@ninolomata could you add your final approval after @D3boker1 changes?

Co-authored-by: Jose Martins <[email protected]>

Signed-off-by: Jose Martins <[email protected]>
D3boker1 and others added 3 commits September 28, 2024 18:34
Co-authored-by: Jose Martins <[email protected]>

Signed-off-by: Jose Martins <[email protected]>
Co-authored-by: Jose Martins <[email protected]>

Signed-off-by: Jose Martins <[email protected]>
@DavidMCerdeira DavidMCerdeira self-requested a review September 29, 2024 15:57
@josecm josecm merged commit ce96cf2 into bao-project:main Sep 30, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants